Skip to content

fix(dsv4): follow AITER FP4 MQA package move - #1966

Merged
valarLip merged 2 commits into
mainfrom
fix/aiter-mqa-logits-imports
Aug 20, 2026
Merged

valarLip merged 2 commits into
mainfrom
fix/aiter-mqa-logits-imports

Conversation

@yhl-amd

@yhl-amd yhl-amd commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update all DeepSeek V4 FP4 MQA decode and prefill imports to the current AITER kernels.mqa_logits package
  • cover both attention-metadata scheduling and model scorer call sites
  • add a CPU-only AST contract test that rejects stale or unexpected FP4 MQA import paths

Context

ROCm/aiter#4609 moved pa_mqa_logits_fp4.py and pa_mqa_logits_fp4_prefill.py under aiter.ops.flydsl.kernels.mqa_logits. ATOM nightly images build AITER from HEAD, while these six lazy imports still referenced the removed flat paths.

DeepSeek V4 on gfx950 with --index-cache-dtype fp4 therefore fails during model warmup with:

ModuleNotFoundError: No module named 'aiter.ops.flydsl.kernels.pa_mqa_logits_fp4_prefill'

The move retained all five APIs used by ATOM, so no call-site or kernel behavior changes are required.

AITER move: ROCm/aiter#4609
Observed failure: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/32338825624/job/96333731386#step:4:1091

Validation

  • executed the new AST import-contract test with Python 3.12
  • compiled both changed production modules and the new test with compileall
  • ran git diff --check
  • verified the five imported symbols are present in the current AITER modules

No GPU workload was run for this import-only change.

@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every eligible PR before approval:

  • ✅ Pre Checkin: Black, Ruff, catalog schema validation, non-GPU unit tests

Heavy model tests:

  • ✅ Run after the PR is approved and Pre Checkin passes
  • ✅ Run immediately when an approval review is submitted
  • ✅ Can be requested before approval with labels
Label Tests
ci:full Run all heavy PR model tests: native ATOM, vLLM, and SGLang
ci:atom Run native ATOM model accuracy tests
ci:vllm Run ATOM vLLM OOT model accuracy tests
ci:sglang Run ATOM SGLang model accuracy tests

Heavy jobs are skipped when the PR is not approved and no matching ci:* label is present.
Add labels via the sidebar or gh pr edit 1966 --add-label <label>

valarLip
valarLip previously approved these changes Aug 20, 2026
@yhl-amd
yhl-amd force-pushed the fix/aiter-mqa-logits-imports branch from 3143712 to 220e2ca Compare August 20, 2026 09:32
@valarLip
valarLip merged commit 024ccc4 into main Aug 20, 2026
62 of 95 checks passed
@valarLip
valarLip deleted the fix/aiter-mqa-logits-imports branch August 20, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants