Revert "[ATOM][Fix] propagate dp_uniform_decode to TBO ubatches" - #1503
Merged
Conversation
This reverts commit 0c7d50f.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a prior change (#1474) that propagated dp_uniform_decode into per-ubatch Context objects created by the TBO micro-batching wrapper.
Changes:
- Removes
dp_uniform_decode=ctx.context.dp_uniform_decodewhen constructing the per-ubatchContextinUBatchWrapper._make_ubatch_context.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
544
to
545
| is_draft=ctx.context.is_draft, | ||
| dp_uniform_decode=ctx.context.dp_uniform_decode, | ||
| ) |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1474