Skip to content

TopK exception bugfix #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
causten merged 7 commits into from
Oct 1, 2025
Merged

TopK exception bugfix #4329

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cd3cce2
TopK exception bugfix
lakhinderwalia Sep 27, 2025
b4e1fb0
Merge branch 'develop' into lw/topk_exception_fix
causten Sep 28, 2025
5393ab0
Merge branch 'develop' into lw/topk_exception_fix
causten Sep 29, 2025
fec5a65
The suggested PR code-change
lakhinderwalia Sep 29, 2025
8f1e306
Excluding via the else-block after if-constexpr() block
lakhinderwalia Sep 29, 2025
f970eb7
rearrange curly braces
lakhinderwalia Sep 29, 2025
ee0ce76
Merge branch 'develop' into lw/topk_exception_fix
causten Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/targets/gpu/kernels/include/migraphx/kernels/index.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,10 @@ struct index
static constexpr void for_stride(index_int start, N n, Stride stride, F f)
{
MIGRAPHX_ASSERT(start < stride);

if constexpr(not is_integral<N>{} and n < 1)
Comment thread
lakhinderwalia marked this conversation as resolved.
return;

Comment thread
lakhinderwalia marked this conversation as resolved.
Outdated
if constexpr(not is_integral<N>{} and not is_integral<Stride>{})
{
if constexpr(max_stride_iterations(n, stride) == 1)
Expand Down
3 changes: 3 additions & 0 deletions test/verify/test_topk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,6 @@ template struct test_topk<migraphx::shape::float_type, 100, 80000>;
template struct test_topk<migraphx::shape::float_type, 1000, 1875>;
template struct test_topk<migraphx::shape::float_type, 1000, 120000>;
template struct test_topk<migraphx::shape::float_type, 1029, 80000>;

template struct test_topk<migraphx::shape::int32_type, 1, 256>;
template struct test_topk<migraphx::shape::int32_type, 1, 1024>;
Loading