-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: shorten subfolders' names #21221
Conversation
I like this change, with my PR I wanted to stay 1:1 with the category titles but yours sound better as folder names 😄 Thank you for putting so much effort into refining my stuff! |
Maybe just |
I tried to have the high-level ones a bit more speaking. But I'm also fine with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, for the bunch of unrelated findings. Besides these cosmetics: ACK from my side.
29f572e
to
405ae1a
Compare
@OlegHahm Thanks for having a detailed read-through! Fixed all the typos ( |
405ae1a
to
cfb5c47
Compare
cfb5c47
to
d4f3626
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used or LINE in $(git show | grep '^+' | grep -oE 'examples[^*,)$"
]*'); do ls -lah ${LINE} > /dev/null ; done` to get a quick overview about potentially invalid path names and found one more case of a broken link.
d4f3626
to
9a45c30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't spot any issues with the latest state so I dare to give an ACK. 👍
Thanks for your thorough review! |
Contribution description
Shorten some subfolder names in the examples directory to make them less verbous:
examples/essentials
=>examples/basic
examples/advanced_examples/
=>examples/advanced
examples/networking/bluetooth_low_energy/misc_ble_examples
=>examples/networking/ble/misc
examples/networking/gnrc_networking
=>examples/networking/gnrc
examples/networking/core_resource_directory
=>examples/networking/cord
examples/language_bindings/{officially,community}_supported
=>examples/lang_support/{official,community}
I'm not particularly happy with
language_bindings
as name either, but could not come up with a shorter one. Maybelanguage_support
would be better although not much shorter?Testing procedure
Check if CI still builds all examples, check working links in examples/README.md
Issues/PRs references
Follow-up of #21135 by @AnnsAnns