Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/sys/shell: improve test automation #21114

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Dec 31, 2024

Contribution description

This improves the test automation by changing the matching to not eagerly match a shell commands description across a line break.

Testing procedure

This hopefully is the issue that causes nightly failures in test runs on tests/sys/shell on samr21-xpro.

Issues/PRs references

None

This changes the matching to not eagerly match a shell commands
description across a line break.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Dec 31, 2024
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Dec 31, 2024
@riot-ci
Copy link

riot-ci commented Dec 31, 2024

Murdock results

✔️ PASSED

8903c82 tests/sys/shell: improve test automation

Success Failures Total Runtime
90 0 90 02m:04s

Artifacts

@maribu
Copy link
Member Author

maribu commented Dec 31, 2024

Seems to indeed fix the issue 🎉

@benpicco benpicco enabled auto-merge December 31, 2024 17:26
@benpicco benpicco added this pull request to the merge queue Dec 31, 2024
Merged via the queue into RIOT-OS:master with commit 74eddd6 Dec 31, 2024
29 checks passed
@maribu maribu deleted the tests/sys/shell branch December 31, 2024 17:38
@maribu
Copy link
Member Author

maribu commented Dec 31, 2024

Thx. Let's see if we start the new year with a green CI again :)

@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants