Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usbus/cdc_ecm: port to netdev_new_api #21028

Merged
merged 1 commit into from
Nov 22, 2024
Merged

usbus/cdc_ecm: port to netdev_new_api #21028

merged 1 commit into from
Nov 22, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

The driver implements a blocking send interface, so the port is trivial.

Testing procedure

Ping still works

2024-11-21 19:13:46,298 # ping ff02::1
2024-11-21 19:13:46,305 # 12 bytes from fe80::eb2f:25e2:a25c:77d2%4: icmp_seq=0 ttl=64 time=0.522 ms
2024-11-21 19:13:47,305 # 12 bytes from fe80::eb2f:25e2:a25c:77d2%4: icmp_seq=1 ttl=64 time=0.615 ms
2024-11-21 19:13:48,305 # 12 bytes from fe80::eb2f:25e2:a25c:77d2%4: icmp_seq=2 ttl=64 time=0.737 ms
2024-11-21 19:13:48,306 # 
2024-11-21 19:13:48,308 # --- ff02::1 PING statistics ---
2024-11-21 19:13:48,313 # 3 packets transmitted, 3 packets received, 0% packet loss
2024-11-21 19:13:48,317 # round-trip min/avg/max = 0.522/0.624/0.737 ms

Issues/PRs references

@github-actions github-actions bot added Area: USB Area: Universal Serial Bus Area: sys Area: System labels Nov 21, 2024
@benpicco benpicco requested a review from maribu November 21, 2024 18:15
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 21, 2024
@riot-ci
Copy link

riot-ci commented Nov 21, 2024

Murdock results

✔️ PASSED

8cd8547 usbus/cdc_ecm: port to netdev_new_api

Success Failures Total Runtime
10249 0 10249 13m:32s

Artifacts

@benpicco benpicco added this pull request to the merge queue Nov 21, 2024
@maribu maribu removed this pull request from the merge queue due to a manual request Nov 21, 2024
@maribu maribu added this pull request to the merge queue Nov 21, 2024
Merged via the queue into RIOT-OS:master with commit 0054f6c Nov 22, 2024
27 checks passed
@benpicco benpicco deleted the usbus_cdc_ecm-netdev_new branch November 22, 2024 13:54
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@dylad dylad Awaiting requested review from dylad dylad is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

Assignees
No one assigned
Labels
Area: sys Area: System Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2025.01
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @maribu @MrKevinWeiss