Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netdev_tap: port to netdev_new_api #21015

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

netdev_tap uses synchronous send, so we can trivially port it to the (relaxed) new netdev API.

Testing procedure

Issues/PRs references

depends on #21012

@github-actions github-actions bot added Platform: native Platform: This PR/issue effects the native platform Area: cpu Area: CPU/MCU ports labels Nov 20, 2024
@benpicco benpicco requested a review from maribu November 20, 2024 22:39
@benpicco benpicco added the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 20, 2024
@benpicco benpicco changed the title netdev_tap: port to netdev_new_api netdev_tap: port to netdev_new_api Nov 20, 2024
@benpicco benpicco force-pushed the cpu/native-netdev_tap-new_api branch from 04f3555 to a71f82d Compare November 20, 2024 23:07
@maribu maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 21, 2024
@maribu
Copy link
Member

maribu commented Nov 21, 2024

This needs a rebase

@riot-ci
Copy link

riot-ci commented Nov 21, 2024

Murdock results

✔️ PASSED

3ba131c netdev_tap: port to netdev_new_api

Success Failures Total Runtime
10249 0 10249 18m:28s

Artifacts

@benpicco benpicco added Area: BLE Area: Bluetooth Low Energy support and removed State: waiting for other PR State: The PR requires another PR to be merged first Area: BLE Area: Bluetooth Low Energy support labels Nov 21, 2024
@benpicco benpicco force-pushed the cpu/native-netdev_tap-new_api branch from a71f82d to 3ba131c Compare November 21, 2024 10:45
@benpicco benpicco added this pull request to the merge queue Nov 21, 2024
@maribu maribu removed this pull request from the merge queue due to a manual request Nov 21, 2024
@maribu maribu added this pull request to the merge queue Nov 21, 2024
@maribu maribu removed this pull request from the merge queue due to a manual request Nov 22, 2024
@maribu maribu added this pull request to the merge queue Nov 22, 2024
Merged via the queue into RIOT-OS:master with commit 87ae06a Nov 22, 2024
25 checks passed
@benpicco benpicco deleted the cpu/native-netdev_tap-new_api branch November 22, 2024 18:14
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants