tests/periph/uart: minor improvements #21009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguetschow
requested review from
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
maribu
approved these changes
Nov 19, 2024
mguetschow
added
the
CI: ready for build
|
Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The UART self-test using a TX-RX-loop fails on
master. Luckily it's not a bug in the UART driver, but just a timing issue betweenuart_writereturning and the HW triggering the RX callback. This PR fixes the test by adding a 1ms delay between TX and RX buffer check.While at it, I also improved the error handling and reporting in the test.
Testing procedure
make -C tests/periph/uart BOARD=nrf52840dk flash term, thentest 1fails onmasterand succeeds with these changes.Issues/PRs references
Encountered while testing for #20980