Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_netif: netdev_new_api implies TX end irq, no need to check it #20993

Merged
merged 5 commits into from
Nov 17, 2024
Merged

gnrc_netif: netdev_new_api implies TX end irq, no need to check it #20993

merged 5 commits into from
Nov 17, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

  • netdev_new_api implies a TX_COMPLETE event, so no need to check for it
  • hide the legacy TX_COMPLETE events behind a MODULE_NETDEV_LEGACY_API check so they are not used by accident when porting a driver to the new API.

Testing procedure

NETOPT_TX_END_IRQ not implemented by driver should go away with netdev_new_api once and for all - the TX_COMPLETE event is now mandated.

Issues/PRs references

@benpicco benpicco requested a review from maribu November 14, 2024 16:43
@github-actions github-actions bot added Area: network Area: Networking Area: drivers Area: Device drivers Area: sys Area: System labels Nov 14, 2024
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Nov 14, 2024
@riot-ci
Copy link

riot-ci commented Nov 14, 2024 •
edited
Loading

Murdock results

✔️ PASSED

8e915ba sys/test_utils: hide legacy events behind netdev_legacy_api

Success Failures Total Runtime
10250 0 10251 18m:43s

Artifacts

@benpicco benpicco added this pull request to the merge queue Nov 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 17, 2024
@maribu maribu added this pull request to the merge queue Nov 17, 2024
Merged via the queue into RIOT-OS:master with commit 51f969d Nov 17, 2024
25 checks passed
@benpicco benpicco deleted the netdev_new_api-enhance branch November 17, 2024 13:59
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2025.01
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @maribu @MrKevinWeiss