drivers/slipdev: port to netdev_new_api #20978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
approved these changes
Nov 12, 2024
|
I agree that this particular driver is not really profiting of the new API. But if we would convert all drivers to the new API, we could - as you said - reduce the complexity of the networking code. So this is very much appreciated :) |
benpicco
force-pushed
the
drivers/slipdev-netdev_new
branch
from
8401266 to
4a8a197
Compare
benpicco
force-pushed
the
drivers/slipdev-netdev_new
branch
from
4a8a197 to
82e5b19
Compare
maribu
approved these changes
Nov 21, 2024
maribu
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Not sure how much sense this makes, since send is still blocking.
I mainly did this to reduce the number of code paths with
at86rf215in the border router use case.Testing procedure
Issues/PRs references