Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/net/gnrc/tcp: fix gnrc_tcp_open() netif handling #20977

Merged
merged 1 commit into from
Nov 13, 2024
Merged

sys/net/gnrc/tcp: fix gnrc_tcp_open() netif handling #20977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions sys/net/gnrc/transport_layer/tcp/gnrc_tcp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
#include "net/af.h"
#include "net/tcp.h"
#include "net/gnrc.h"
#include "net/gnrc/netif.h"
#include "net/gnrc/tcp.h"
#include "net/sock.h"
#include "include/gnrc_tcp_common.h"
#include "include/gnrc_tcp_fsm.h"
#include "include/gnrc_tcp_pkt.h"
Expand Down Expand Up @@ -394,6 +396,24 @@ int gnrc_tcp_open(gnrc_tcp_tcb_t *tcb, const gnrc_tcp_ep_t *remote, uint16_t loc
return -EINVAL;
}
tcb->ll_iface = remote->netif;

/* When the target is a link-local address and no netif is specified,
* this would otherwise not send out any data and timeout. If only
* a single netif is there, we can just take that. */
if (ipv6_addr_is_link_local((const ipv6_addr_t *)tcb->peer_addr)
&& tcb->ll_iface == SOCK_ADDR_ANY_NETIF) {
benpicco marked this conversation as resolved.
Show resolved Hide resolved
const gnrc_netif_t *first_netif = gnrc_netif_iter(NULL);
if (!first_netif) {
/* There is no netif at all */
return -EINVAL;
}
if (!gnrc_netif_highlander() && gnrc_netif_iter(first_netif)) {
/* There is at least one other netif present. We are forcing
* the use to pick one */
return -EINVAL;
}
tcb->ll_iface = first_netif->pid;
}
}
#endif

Expand Down
Loading