Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/esp32/stdio_usb_serial_jtag: Fix to ESP32 stdio usb serial hanging if it receives data too quickly #20972

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpu/esp32/stdio_usb_serial_jtag/usb_serial_jtag.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
static uint8_t serial_tx_rb_buf[USB_SERIAL_JTAG_PACKET_SZ_BYTES];

#define IRQ_MASK (USB_SERIAL_JTAG_INTR_SERIAL_IN_EMPTY | \
(IS_USED(MODULE_STDIO_USB_SERIAL_JTAG_RX) * USB_SERIAL_JTAG_INTR_SERIAL_OUT_RECV_PKT))

Check warning on line 39 in cpu/esp32/stdio_usb_serial_jtag/usb_serial_jtag.c

View workflow job for this annotation

GitHub Actions / static-tests

line is longer than 100 characters

static ssize_t _write(const void *buffer, size_t len)
{
Expand Down Expand Up @@ -73,11 +73,11 @@
}
USB_SERIAL_JTAG.ep1.rdwr_byte = c;
}
usb_serial_jtag_ll_txfifo_flush();
}

/* clear all interrupt flags */
usb_serial_jtag_ll_clr_intsts_mask(mask);
usb_serial_jtag_ll_clr_intsts_mask(USB_SERIAL_JTAG_LL_INTR_MASK);
usb_serial_jtag_ll_txfifo_flush();

irq_isr_exit();
}
Expand Down
Loading