Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefiles: quiet messages on CI #18470

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

MrKevinWeiss
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss commented Aug 18, 2022

Contribution description

After introducing #18423 there are occasional messages that still happen.
These messages cause a diff output when testing with TEST_KCONFIG=1.
This then causes a failure when comparing make/kconfig modules and packages.

Testing procedure

rm -f dist/tools/kconfiglib/menuconfig.py && /bin/bash -c "source .murdock; compile tests/shell native:gnu"

Issues/PRs references

Introduced in #18423
Discovered by #18466

@MrKevinWeiss MrKevinWeiss added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Aug 18, 2022
@github-actions github-actions bot added Area: build system Area: Build system Area: tools Area: Supplementary tools labels Aug 18, 2022
@MrKevinWeiss MrKevinWeiss added Area: CI Area: Continuous Integration of RIOT components and removed Area: build system Area: Build system Area: tools Area: Supplementary tools labels Aug 18, 2022
@MrKevinWeiss MrKevinWeiss changed the title makefiles: quite messages on CI makefiles: quiet messages on CI Aug 18, 2022
@MrKevinWeiss MrKevinWeiss force-pushed the pr/fixmurdockloudness branch from 64a256b to 385a115 Compare August 18, 2022 12:00
@github-actions github-actions bot added Area: build system Area: Build system Area: tools Area: Supplementary tools and removed Area: CI Area: Continuous Integration of RIOT components labels Aug 18, 2022
@MrKevinWeiss
Copy link
Contributor Author

ping @maribu @benpicco @leandrolanzieri

@MrKevinWeiss MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 18, 2022
@MrKevinWeiss
Copy link
Contributor Author

Hmmm will that work or will it still show

git-cache: cloning from cache. tag=commit061e71f7d78cb057762d88de088055361863deff-1639

On the output failure we see it:

-- running on worker riotbuild-4 thread 2, build number 30999.
make: Entering directory '/tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/tests/test_tools'
make: Leaving directory '/tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/tests/test_tools'
make: Entering directory '/tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/tests/test_tools'
Building application "tests_test_tools" for "dwm1001" with MCU "nrf52".

sha1sum /tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/tests/test_tools/tests/01-run.py /tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/build/tests_test_tools.bin > /tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/build/test-input-hash.sha1
   text	   data	    bss	    dec	    hex	filename
  10088	    128	   2632	  12848	   3230	/tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/build/tests_test_tools.elf
make: Leaving directory '/tmp/dwq.0.6542732782276176/7c47d59c9617da36c7b13142d81eb830/tests/test_tools'
0a1,3
> [INFO] Kconfiglib not found - getting it
> git-cache: cloning from cache. tag=commit061e71f7d78cb057762d88de088055361863deff-1639
> [INFO] Kconfiglib downloaded
{"build/": 1864}

But locally I don't. Let me keep testing.

@MrKevinWeiss
Copy link
Contributor Author

Nope still doesn't work... let me keep trying...

@MrKevinWeiss MrKevinWeiss force-pushed the pr/fixmurdockloudness branch from 385a115 to c7f6adf Compare August 18, 2022 12:11
@MrKevinWeiss
Copy link
Contributor Author

OK better test and better results. Now I am happy.

@MrKevinWeiss
Copy link
Contributor Author

Heh, well that super didn't work... I will have to revisit it when I have time.

@MrKevinWeiss MrKevinWeiss force-pushed the pr/fixmurdockloudness branch from c7f6adf to 6e9968d Compare August 22, 2022 08:00
@MrKevinWeiss MrKevinWeiss added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: full build disable CI build filter and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 22, 2022
@MrKevinWeiss
Copy link
Contributor Author

Strange error now:

-- running on worker mobi3 thread 17, build number 131395.
make: Entering directory '/tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/examples/suit_update'
# Reset package to checkout state.
rm -rf /tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/build/pkg/c25519
rm -rf /tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/build/pkg-build/libcose
rm -rf /tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/build/pkg-build/littlefs2
rm -rf /tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/build/pkg-build/nanocbor
make: Leaving directory '/tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/examples/suit_update'
make: Entering directory '/tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/examples/suit_update'
make: *** No rule to make target '/tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/examples/suit_update/bin/native/suit_update/fw.1661156187.bin', needed by 'link'.  Stop.
make: *** Waiting for unfinished jobs....
Building application "suit_update" for "native" with MCU "native".

make: Leaving directory '/tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/examples/suit_update'
cat: /tmp/dwq.0.5019332222865925/1890ed54c1c4f32158d9d853786b47a4/build/test-input-hash.sha1: No such file or directory

rerunning

@MrKevinWeiss
Copy link
Contributor Author

Maybe a mobi3 specific problem? Running locally seems to work.

@MrKevinWeiss
Copy link
Contributor Author

As my make knowledge is not so great maybe it would be worth looking at the code. I simply want to quiet the output if RIOT_CI_BUILD is 1, but still clone and build the kconfig library if it is missing.

If this passes it is probably good to merge in before starting other builds as this would prevent the false positives. My only concern is that maybe all the conditions are not hit in this run (ie, all the libs are build but if we clean out a worker it will throw different errors).

@@ -3,9 +3,13 @@ MENUCONFIG ?= $(RIOTTOOLS)/kconfiglib/riot_menuconfig.py
BASE_MENUCONFIG ?= $(RIOTTOOLS)/kconfiglib/menuconfig.py
GENCONFIG := $(RIOTTOOLS)/kconfiglib/genconfig.py

ifeq ($(RIOT_CI_BUILD),1)
QUIETMESSAGES=":"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is : supposed to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the make way to optionally quiet the echos...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very open to suggestions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh TIL, I only knew about @ to silence echoing the command

@MrKevinWeiss
Copy link
Contributor Author

We could also hit it from diff side. The whole issues is that there is extra output when using info-modules info-packages, I just do a simple diff. Maybe we can either strip extras or have different targets that are a bit more robust or so.

This is getting to one of those issues where in theory it is simple but reality becomes more and more complex with a whole bunch of small corner cases.

After introducing RIOT-OS#18423 there are occasional messages that still happen.
These messages cause a diff output when testing with TEST_KCONFIG=1.
This then causes a failure when comparing make/kconfig modules and packages.
@MrKevinWeiss MrKevinWeiss force-pushed the pr/fixmurdockloudness branch from 6e9968d to 0489630 Compare August 22, 2022 09:36
@MrKevinWeiss
Copy link
Contributor Author

Pushed the fixes and squashed

@benpicco benpicco enabled auto-merge August 22, 2022 11:26
@benpicco benpicco merged commit 6c6ebce into RIOT-OS:master Aug 22, 2022
@MrKevinWeiss MrKevinWeiss deleted the pr/fixmurdockloudness branch August 22, 2022 11:33
@MrKevinWeiss
Copy link
Contributor Author

Nice, thanks @benpicco. Let's hope that is the last of it.

@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: tools Area: Supplementary tools CI: full build disable CI build filter CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants