-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefiles: quiet messages on CI #18470
Conversation
64a256b
to
385a115
Compare
Hmmm will that work or will it still show
On the output failure we see it:
But locally I don't. Let me keep testing. |
Nope still doesn't work... let me keep trying... |
385a115
to
c7f6adf
Compare
OK better test and better results. Now I am happy. |
Heh, well that super didn't work... I will have to revisit it when I have time. |
c7f6adf
to
6e9968d
Compare
Strange error now:
rerunning |
Maybe a mobi3 specific problem? Running locally seems to work. |
As my make knowledge is not so great maybe it would be worth looking at the code. I simply want to quiet the output if If this passes it is probably good to merge in before starting other builds as this would prevent the false positives. My only concern is that maybe all the conditions are not hit in this run (ie, all the libs are build but if we clean out a worker it will throw different errors). |
makefiles/tools/kconfiglib.inc.mk
Outdated
@@ -3,9 +3,13 @@ MENUCONFIG ?= $(RIOTTOOLS)/kconfiglib/riot_menuconfig.py | |||
BASE_MENUCONFIG ?= $(RIOTTOOLS)/kconfiglib/menuconfig.py | |||
GENCONFIG := $(RIOTTOOLS)/kconfiglib/genconfig.py | |||
|
|||
ifeq ($(RIOT_CI_BUILD),1) | |||
QUIETMESSAGES=":" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is :
supposed to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the make way to optionally quiet the echos...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very open to suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh TIL, I only knew about @
to silence echoing the command
We could also hit it from diff side. The whole issues is that there is extra output when using This is getting to one of those issues where in theory it is simple but reality becomes more and more complex with a whole bunch of small corner cases. |
After introducing RIOT-OS#18423 there are occasional messages that still happen. These messages cause a diff output when testing with TEST_KCONFIG=1. This then causes a failure when comparing make/kconfig modules and packages.
6e9968d
to
0489630
Compare
Pushed the fixes and squashed |
Nice, thanks @benpicco. Let's hope that is the last of it. |
Contribution description
After introducing #18423 there are occasional messages that still happen.
These messages cause a diff output when testing with TEST_KCONFIG=1.
This then causes a failure when comparing make/kconfig modules and packages.
Testing procedure
Issues/PRs references
Introduced in #18423
Discovered by #18466