cdc_ecm: Truncate frames at max ethernet size #17200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This truncates the incomming frames to ETHERNET_FRAME_LEN and silently discards the rest of the frame until the end of the frame. This should be modified to an endpoint halt condition after RIOT-OS#17090 is merged, but for now this should be good enough. Stalling the endpoint with the current stall implementation could cause a ping of death scenario, so for now the data is truncated until the above solution can be implemented.
bergzand
added
Type: bug
dylad
added
Reviewed: 1-fundamentals
dylad
approved these changes
Nov 15, 2021
dylad
added
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This truncates the incomming frames to ETHERNET_FRAME_LEN and silently
discards the rest of the frame until the end of the frame. This should
be modified to an endpoint halt condition after #17090 is merged, but
for now this should be good enough.
Stalling the endpoint with the current stall implementation could cause
a ping of death scenario, so for now the data is truncated until the
above solution can be implemented.
(I've also removed an duplicate
USBOPT_EP_AVAILABLEcall)Testing procedure
The
tests/usbus_cdc_ecmapplication should still work on a platform of choice.Issues/PRs references
Reported in detail by @szymonh