netdev/ieee802154_submac: enable ACK_REQ by default #15210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
changed the title
benpicco
added
Area: network
|
good catch :) |
jia200x
reviewed
Oct 12, 2020
One of the features of the sub-MAC is to allow for ACK-handling in software. So enable the use of ACKs by default, just like the netdev drivers do that support this feature in hardware.
benpicco
force-pushed
the
ieee802154_submac-ack_req
branch
from
b1d818d to
bb54683
Compare
benpicco
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
One of the features of the sub-MAC is to allow for ACK-handling in software.
So enable the use of ACKs by default, just like the netdev drivers do that support this feature in hardware.
Testing procedure
Issues/PRs references
searched quite a bit why ACKs were not working in #14448 (comment)