-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/at86rf2xx: support frame retry reporting on AT86RFR2 #14596
Conversation
@aabadie has the hardware and could test! |
Testing this PR with
No idea if this is expected or not. |
If it gets no ACK is will re-try as often as you have configured it to do. |
Thanks but sorry, I don't know about it that much. Do you have something more precise ? |
I don't have the hardware with me, but conceptually makes sense to me |
The radio will send the the frame a number of times until it receives an ACK from the destination if the ACK requested flag is set. If you send a packet to a node that doesn't exist, the radio will try that many times to deliver the packet. |
At86rfr2 doesn't report retries directly, but it can generate a TX start interrupt for each (re)try, so we can count manually.
ea615e4
to
0871b69
Compare
So I guess the output was correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Contribution description
AT86RFR2 doesn't report retries directly, but it can generate a TX start interrupt for each (re)try, so we can count manually.
Testing procedure
Currently retry count is not used anywhere in RIOT.
So you will either need #14448 or you manually add
to check that retries are reported correctly.
Issues/PRs references
Missing feature from #9172