drivers/at86rf215: implement MR-O-QPSK #13912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds PHY modes for IEEE 802.15.4-2003 and IEEE 802.15.4g-2012.
benpicco
added
Type: new feature
benpicco
requested review from
cgundogan,
haukepetersen,
miri64 and
PeterKietzmann
as code owners
|
I've played around with sending packets with different configurations and everything is working. |
benpicco
force-pushed
the
at86rf215-mr-qpsk
branch
from
4d2dd08 to
49535fe
Compare
|
My change requests have been addressed, I currently only have access to 1 @benpicco could you provide some test output for |
|
|
@benpicco please squash! |
Define options for IEEE 802.15.4g MR-O-QPSK as well as shell commands to set them via ifconfig.
All option have a space behind them. This fixes the formatting of the NID parameter if there are options after it.
IEEE 802.15.4g-2012 specifies a PDU of 2047 for it's PHY modes, so query the driver for the mode before returning the PDU. If none of the new modes is used, don't query the driver to not incure a penalty on existing platforms.
benpicco
added
the
CI: ready for build
benpicco
force-pushed
the
at86rf215-mr-qpsk
branch
from
32d5694 to
6ce0092
Compare
|
I also printed the size of the TX frame to check if GNRC correctly picks up the larger PDU: |
fjmolinas
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
ACK, my change rquests have been addressed. I did some initial testing at the start of the review when I had the required HW, @benpicco provided test output again at the end of the review process. I also tested that default configuration was still working.
|
Thank you for the review! I'll try to add MR-OFDM and MR-FSK soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This adds MR-O-QPSK modulation to the
at86rf215driver.This also adds new commands to
ifconfigto configure the new modulation parameters.Testing procedure
Switch to the new PHY mode with
ifconfig 7 set phy_mode mr-o-qpsk. Note that theL2-PDUhas changed to 2022 bytes (802.15.4g can send 2047 byte frames).You can now change the rate mode with
ifconfig 7 set rate_mode 3(range: 0…4) and the chip rate withifconfig 7 set chips 1000(possible values: 100, 200, 1000 & 2000 chip/s)Issues/PRs references
split off #12128 but now the timings should be correct.