Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/lwip: add support for esp32 Ethernet device #12950

Merged
merged 5 commits into from
Dec 16, 2019
Merged

pkg/lwip: add support for esp32 Ethernet device #12950

merged 5 commits into from
Dec 16, 2019

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR adds the support for ESP32 Ethernet device to pkg/lwip in same way as PR #12895 does. Addititionally, it adds the IPv4 support for the ESP32 Ethernet device as PR #12903.

Testing procedure

Flash tests/lwip with enabled module esp_wifi on any ESP32 board with an Ethernet interface (for example Olimex ESP32-EVB)

USEMODULE=esp_eth make BOARD=esp32-olimex-evb -C tests/lwip flash term

and execute ifconfig on ESP32 node and ping the node from any machine in the LAN.

Issues/PRs references

Related to PR #12903.

@gschorcht gschorcht added Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: new feature The issue requests / The PR implemements a new feature for RIOT and removed Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Dec 14, 2019
@benpicco benpicco mentioned this pull request Dec 15, 2019
Merged
benpicco
benpicco approved these changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just follows the same pattern contrib/lwip.c.

benpicco
benpicco reviewed Dec 15, 2019
View reviewed changes
@benpicco
Copy link
Contributor

Please squash!

@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 15, 2019
@gschorcht
Copy link
Contributor Author

@benpicco Squashed.

@benpicco benpicco merged commit 8c4498a into RIOT-OS:master Dec 16, 2019
@gschorcht gschorcht deleted the cpu/esp32/lwip_eth branch December 16, 2019 09:54
@gschorcht
Copy link
Contributor Author

Thanks for reviewing and merging.

@gschorcht gschorcht mentioned this pull request Dec 16, 2019
Merged
@miri64 miri64 mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
3 participants
@gschorcht @benpicco @fjmolinas