-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell_commands: gnrc_netif: only include LoRA options when LoRA PHY is present #12295
Conversation
Re-queued build, as the PR is still under discussion. |
LGTM now. Let's see, what the LoRA crowd says to this. |
Mh... thought re-requesting my review would work. Oh well, then I dismiss it formally
(IMHO this PR can be squashed) |
…s present If no LoRA module is used, there is no use in compiling in all the config options for LoRA PHYs. This saves about 1k of .text
1ae5a2e
to
c31e373
Compare
LGTM. I will test it now on real hardware |
Tested on hardware (samr21-xpro and b-l072z-lrwan1). LoRa options are shown only in the b-l072z-lrwan1 (equipped with a LoRa radio). So it works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
...& GO |
Thank you both for the fast review & test! |
Contribution description
If no LoRA module is used, there is no use in compiling in all the config options for LoRA PHYs.
This saves about 1k of
.text
.It also slims down the switch case in
_print_netopt
.Right now, adding only one more entry there will cause an error on AVR:
This is because there are too many cases and local jumps on that platform can only be so far.
Testing procedure
Compile e.g.
examples/gnrc_networking
forsamr21-xpro
Before:
After:
Examples using the sx127x module should continue to work.
Issues/PRs references
this adapts the idea from #12171 to existing code.
In that PR, drivers will select a pseudomodule to indicate which PHY options they support