Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kw2xrf: Don't use netdev_ieee802154_t for channel #10535

Merged
merged 3 commits into from
Dec 3, 2018

Conversation

bergzand
Copy link
Member

@bergzand bergzand commented Dec 3, 2018

Contribution description

This PR modifies the behaviour of the kw2xrf driver to not propagate the channel to the netdev_ieee802154_t struct. This helps the goal of separating the netdev and the ieee802154_t layer by another bit. The end goal is to remove the channel from the netdev_ieee802154_t struct.

The performance impact of this change should be negligible, the NETOPT_CHANNEL call is only used by the ifconfig command.

Testing procedure

Please test whether:

  • ifconfig still shows the correct channel. These should not have changed between this PR and master.

Unable to test this myself at the moment, somebody is blocking access to the phynode@saclay :-)

Issues/PRs references

Part of #7736

This modification changes the netdev::set function for the kw2xrf to not
propagate the NETOPT_CHANNEL to the generic netdev_ieee802154 code
@bergzand bergzand added Area: network Area: Networking Area: drivers Area: Device drivers labels Dec 3, 2018
@bergzand bergzand requested a review from miri64 December 3, 2018 09:22
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I was able to exchange packets between a phynode and samr21-xpro on channel 11 (set at compile time using DEFAULT_CHANNEL) using example/default. ifconfig showed the correct channel. The packets also appeared in a dump sniffing channel 11. I then switched over to channel 26 using ifconfig 4 set chan 26. ifconfig still showed the expected result, exchanging packets still worked, but as expected the sniffer did not pick up those packets (but did when restarting with channel 26).

@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 3, 2018
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DupACK! Tested with PhyNode, works as described

@smlng smlng merged commit f492bbd into RIOT-OS:master Dec 3, 2018
@aabadie aabadie added this to the Release 2019.01 milestone Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants