Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc2538_rf: Don't use netdev_ieee802154_t for channel #10426

Merged
merged 2 commits into from
Nov 25, 2018
Merged

cc2538_rf: Don't use netdev_ieee802154_t for channel #10426

merged 2 commits into from
Nov 25, 2018

Conversation

bergzand
Copy link
Member

Contribution description

This PR modifies the behaviour of the cc2538_rf driver to not propagate the channel to the netdev_ieee802154_t struct. This helps the goal of separating the netdev and the ieee802154_t layer by another bit. The end goal is to remove the channel from the netdev_ieee802154_t struct.

The performance impact of this change should be negligible, the NETOPT_CHANNEL call is only used by the ifconfig command.

Testing procedure

Test whether:

  • ifconfig still shows the correct channel. These should not have changed between this PR and master.

Issues/PRs references

related to #10401, part of #7736

disclaimer: I don't own a board with the cc2538 on it so I'm flying blind here. As long as the actual channel getter work, the code should work.

@bergzand bergzand added Area: network Area: Networking Area: drivers Area: Device drivers labels Nov 17, 2018
@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 17, 2018
@bergzand
Copy link
Member Author

Tested with two firefly boards on the IoT-LAB, appears to work for me.

miri64
miri64 requested changes Nov 18, 2018
View reviewed changes
smlng
smlng approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on remote-rev, ACK! Still shows the channel, how was it handled before anyway?

@smlng smlng added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Nov 22, 2018
@smlng
Copy link
Member

smlng commented Nov 22, 2018

please squash

miri64
miri64 approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment was addressed. Please squash.

@bergzand bergzand force-pushed the pr/cc2538_rf/undedup_channel branch from edbb4f6 to 8970446 Compare November 25, 2018 09:47
@bergzand
Copy link
Member Author

Squashed!

Still shows the channel, how was it handled before anyway?

getters and setters are also in the netdev_ieee802154. almost all radios pass the NETOPT_CHANNEL requests to the netdev_ieee802154 code.

@miri64 miri64 merged commit 7a8469f into RIOT-OS:master Nov 25, 2018
@aabadie aabadie added this to the Release 2019.01 milestone Dec 2, 2018
@miri64 miri64 added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

@smlng smlng smlng approved these changes

@jnohlgard jnohlgard Awaiting requested review from jnohlgard

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.01
Development

Successfully merging this pull request may close these issues.
4 participants
@bergzand @smlng @miri64 @aabadie