Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc2538_rf: Don't use netdev_ieee802154_t for link layer address #10425

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

bergzand
Copy link
Member

Contribution description

This PR modifies the behaviour of the cc2538_rf driver to not propagate the link layer address to the netdev_ieee802154_t struct. This helps the goal of separating the netdev and the ieee802154_t layer by another bit. The end goal is to remove the short and long address from the netdev_ieee802154_t struct and match the behaviour of the ethernet drivers.

The performance impact of this change should be negligible, the NETOPT_ADDRESS(_LONG) call is only used on initialization and by the ifconfig command.

Testing procedure

Test whether:

  • ifconfig still shows the correct link layer addresses. These should not have changed between this PR and master.
  • ping still works. This to verify that the link layer address is also properly configured in the radio, if the ping echo/reply fails, the address filter of the radio might be configured in the wrong endianness.

Issues/PRs references

related to #10401, part of #7736

disclaimer: I don't own a board with the cc2538 on it so I'm flying blind here. As long as the actual address getters work, the code should work.

@bergzand bergzand added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Area: drivers Area: Device drivers labels Nov 17, 2018
@bergzand bergzand changed the title Pr/cc2538 rf/undedup address cc2538_rf: Don't use netdev_ieee802154_t for link layer address Nov 17, 2018
@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 17, 2018
@aabadie
Copy link
Contributor

aabadie commented Nov 18, 2018

I don't own a board with the cc2538 on it so I'm flying blind here.

@bergzand, just in case, there are Zolertia Firefly (cc2538 based boards) deployed on the Lille site of IoT-LAB.

@bergzand
Copy link
Member Author

@bergzand, just in case, there are Zolertia Firefly (cc2538 based boards) deployed on the Lille site of IoT-LAB.

I wasn't aware of that, thanks for letting me know.

@bergzand
Copy link
Member Author

Tested with two firefly boards on the IoT-LAB, appears to work for me.

Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with remote-revb, ACK!

@smlng smlng added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Nov 22, 2018
@miri64 miri64 merged commit 3771e6a into RIOT-OS:master Nov 22, 2018
@aabadie aabadie added this to the Release 2019.01 milestone Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants