mrf24j40: Don't use netdev_ieee802154_t for link layer address #10402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergzand
added
Type: enhancement
|
The last commit replaces a number of shifts by |
bergzand
added
the
State: waiting for other PR
|
blocking until #10537 is merged |
|
#10537 got merged into master. Please rebase. |
bergzand
force-pushed
the
pr/mrf24j40/undedup_address
branch
from
d69115a to
4ea4aae
Compare
|
Rebased! |
bergzand
removed
the
State: waiting for other PR
|
@gschorcht can you test this? |
miri64
previously requested changes
Jan 12, 2019
drivers/mrf24j40/mrf24j40_getset.c
Outdated
| #ifdef MODULE_SIXLOWPAN | ||
| /* https://tools.ietf.org/html/rfc4944#section-12 requires the first bit to | ||
| * 0 for unicast addresses */ | ||
| dev->netdev.short_addr[0] &= 0x7F; | ||
| naddr.u8[0] &= 0xFF7F; |
There was a problem hiding this comment.
left is uint8_t, right is signed with at least 16-byte defined. Why don't keep it 0x7F as in the original?
This change modifies the mrf24j40 driver to read the address directly from the device instead of returning the netdev_ieee802154_t member
bergzand
force-pushed
the
pr/mrf24j40/undedup_address
branch
from
4ea4aae to
e29ebc7
Compare
|
Reworded the first commit message as it mentioned the |
Of course, I will do it tomorrow. |
miri64
dismissed
their stale review
ACK, my comment was addressed and now it only removes the (addressing) dependency from the netdev_ieee802154_t struct.
miri64
added
Reviewed: 1-fundamentals
miri64
reviewed
Jan 12, 2019
| *(uint64_t*)val = mrf24j40_get_addr_long(dev); | ||
| res = sizeof(uint64_t); | ||
| } | ||
| break; |
There was a problem hiding this comment.
Ok this part is different, but it makes sense and is sane ;-)
|
work as expected |
gschorcht
added
the
Reviewed: 3-testing
|
@bergzand please squash |
bergzand
force-pushed
the
pr/mrf24j40/undedup_address
branch
from
e29ebc7 to
a6e7882
Compare
|
squashed! |
miri64
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR modifies the behaviour of the mrf24j40 driver to not propagate the link layer address to the netdev_ieee802154_t struct. This helps the goal of separating the netdev and the ieee802154_t layer by another bit. The end goal is to remove the short and long address from the netdev_ieee802154_t struct and match the behaviour of the ethernet drivers.
The performance impact of this change should be negligible, the NETOPT_ADDRESS(_LONG) call is only used on initialization and by the ifconfig command.
Testing procedure
Test whether:
Issues/PRs references
related to #10401, part of #7736