Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename esplora into esplora_blocking and do a dedicated resolver module #103

Closed
wants to merge 8 commits into from

Conversation

dr-orlovsky
Copy link
Member

No description provided.

@dr-orlovsky dr-orlovsky added the enhancement New feature or request label Jan 19, 2024
Copy link
Member

@crisdut crisdut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, configure bp-wallet and bp-esplora as:

bp-wallet = { version = "0.11.0-beta.4", default-features = false, features = ["fs", "serde"] }
bp-esplora = { version = "0.11.0-beta.2", default-features = false }

Also, you need remove cli from default-members:

default-members = [
    "psbt",
    "fs",
    "."
]

@dr-orlovsky
Copy link
Member Author

@crisdut can you please explain this part:

Please, configure bp-wallet and bp-esplora as:

I am not getting where to put that strings

@cryptoquick
Copy link
Member

@crisdut can you please explain this part:

Please, configure bp-wallet and bp-esplora as:

I am not getting where to put that strings

They just go into the Cargo.toml, replacing the existing entries for bp-wallet and bp-esplora.

@crisdut
Copy link
Member

crisdut commented Feb 6, 2024

Hi @dr-orlovsky

Would you like some help with this PR?

@dr-orlovsky
Copy link
Member Author

@crisdut yeah, that would be much appreciated since I still do not get what specifically have to be done

@crisdut crisdut mentioned this pull request Feb 10, 2024
@dr-orlovsky dr-orlovsky mentioned this pull request Feb 13, 2024
@dr-orlovsky
Copy link
Member Author

This PR got a mix of features, and a couple of merges of other PRs for the changes which should went into the master and not here. Thus, I split it into topic-/feature-related PRs and close it for now.

  1. Fix for Opret invalidly merged here from fix opret support #112 went to Fix opret support in construct_psbt() #130 and merged to master
  2. A separate PR addressing all electrum-specific changes has cherry-picked all related commits from here: Add electrum support #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants