Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rsyntax #1560

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Rsyntax #1560

merged 3 commits into from
Sep 12, 2024

Conversation

randy3k
Copy link
Member

@randy3k randy3k commented Sep 8, 2024 •
edited
Loading

  • remove the variable.other.r scope to make the syntax highlighting rule more consistent with other languages such as python
  • httpgd 0.1.7 doesn't pass npm pretest
  • fix a bunch of npm audit

dependabot bot and others added 3 commits September 3, 2024 22:14
@dependabot
Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows
b044f75 
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@randy3k
Remove variable.other.r
7682335 
To be more consistant with other languages such as python
@randy3k
Pin httpgd 0.1.6
9a2acab 
0.1.7 doesn't pass npm pretest
@randy3k randy3k requested a review from renkun-ken September 8, 2024 05:41
@randy3k
Copy link
Member Author

randy3k commented Sep 8, 2024

@renkun-ken
Do you mind adding me as another owner in the openvsx registry? I have decided to put more time in vscode, so it may make sense to me to be able to publish to openvsx. Thanks.

renkun-ken
renkun-ken approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@renkun-ken renkun-ken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@renkun-ken renkun-ken merged commit c937cdd into master Sep 12, 2024
16 checks passed
@renkun-ken
Copy link
Member

renkun-ken commented Sep 12, 2024 •
edited
Loading

@renkun-ken Do you mind adding me as another owner in the openvsx registry? I have decided to put more time in vscode, so it may make sense to me to be able to publish to openvsx. Thanks.

Of course... done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renkun-ken renkun-ken renkun-ken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randy3k @renkun-ken