Use non-deprecated pyparsing methods#3362
Merged
edmondchuc merged 11 commits intoRDFLib:7.xfrom Feb 13, 2026
Merged
Conversation
kevinstadler
added a commit
to erc-releven/releven-backend
that referenced
this pull request
Jan 13, 2026
kevinstadler
added a commit
to erc-releven/releven-backend
that referenced
this pull request
Jan 13, 2026
e65b915 to
45eedcf
Compare
Contributor
|
I've updated the PR to preserve handling of empty solutions in 70fe2f7. |
Contributor
|
I've rebased the commits onto 7.x and updated the target branch, assuming the change would be non-breaking. However, I’m not sure the compatibility claim holds:
The failing CI check ensures all tests pass on the minimum supported Python runtime and dependency versions, which resolves pyparsing to version 2.1.0. With that version, we're seeing multiple test failures due to import errors. This suggests the change is not backwards compatible and may require either:
|
15 tasks
Contributor
|
I've added a pyparsing v2 and v3 import compat layer in 59f585c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR fixes #3361 by changing the deprecated methods from pyparsing to the PEP8-compliant, non-deprecated ones.
These methods are available since pyparsing 3.0.0. Since rdflib requires pyparsing >=3.2.0,<4, this change is backwards compatible.
Checklist
the same change.
7612 passed, 591 skipped, 330 xfailed, 36 xpassed, 36000 warnings in 121.93s (0:02:01)so maintainers can fix minor issues and keep your PR up to date.