reworked documentation of JSONLDSerializer.#3323
Open
WhiteGobo wants to merge 2 commits intoRDFLib:7.xfrom
Open
reworked documentation of JSONLDSerializer.#3323WhiteGobo wants to merge 2 commits intoRDFLib:7.xfrom
WhiteGobo wants to merge 2 commits intoRDFLib:7.xfrom
Conversation
… shown as parameter in serialize. Added docstrings. No functional change.
edmondchuc
reviewed
Feb 13, 2026
| ) | ||
|
|
||
| context_data = kwargs.get("context") | ||
| use_native_types = (kwargs.get("use_native_types", False),) |
Contributor
There was a problem hiding this comment.
I just want to point out that use_native_types was previously a tuple(False,) whereas the new code changes it to a bool.
This alters the runtime behaviour, so it may not be strictly backwards compatible. I'm not sure whether the original tuple was intentional or an oversight.
@WhiteGobo what are your thoughts on this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still work in correspondence to #3307.
Added missing documentation arguments.
Working towards that all arguments are accesible with
inspect.Summary of changes
Added more documentation to module and
JsonLDSerializer.serialize.Moved Arguments to serialize arguments, instead of extracting them from
**args.No functional change, but because i dont extract anything from
**argsanymore, there are some changes in the program code.Still missing explanation to argument
context.Added docstring to
PLAIN_LITERAL_TYPES.Added crosslink to
graph.serializeChecklist
the same change.
./examples.so maintainers can fix minor issues and keep your PR up to date.