Skip to content

allow sphinx-autodoc-typehints to be upgraded to 2.3.x#2913

Closed
mr-c wants to merge 1 commit intoRDFLib:mainfrom
mr-c:sphinx-autodoc-typehints
Closed

allow sphinx-autodoc-typehints to be upgraded to 2.3.x#2913
mr-c wants to merge 1 commit intoRDFLib:mainfrom
mr-c:sphinx-autodoc-typehints

Conversation

@mr-c
Copy link
Contributor

@mr-c mr-c commented Sep 26, 2024

Summary of changes

Allow installing with sphinx-autodoc-typehints version up to version 2.3.x in Python 3.9+ systems.

Currently this results in an error while building docs, hence this PR being in draft state, see #2912

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change adds new features or changes the RDFLib public API:
    • Created an issue to discuss the change and get in-principle agreement.
    • Considered adding an example in ./examples.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@ashleysommer
Copy link
Contributor

After RDFLib v7.1.0 releases, we will drop Python 3.8 support, and from RDFLib v8.0 we have only Python 3.9+.

@mr-c mr-c force-pushed the sphinx-autodoc-typehints branch from b35a1c1 to 9f30985 Compare October 21, 2024 10:58
@ashleysommer
Copy link
Contributor

ashleysommer commented Nov 6, 2024

@mr-c
Are you able to please rebase your PR against the new changes in the main branch, you will no longer need the python >= 3.9 conditionals in the pyproject.toml.

@mr-c mr-c force-pushed the sphinx-autodoc-typehints branch from 9f30985 to 03e3742 Compare November 6, 2024 08:01
@mr-c mr-c changed the title WIP: allow sphinx-autodoc-typehints to be upgraded to 2.3.x on Python 3.9+ allow sphinx-autodoc-typehints to be upgraded to 2.3.x Nov 6, 2024
@mr-c
Copy link
Contributor Author

mr-c commented Nov 6, 2024

@mr-c Are you able to please rebase your PR against the new changes in the main branch, you will no longer need the python >= 3.9 conditionals in the pyproject.toml.

Done, thank you for the reminder. The docs build fails still, as before: https://github.com/RDFLib/rdflib/actions/runs/11699448011/job/32581466682?pr=2913#step:9:2223

@ashleysommer
Copy link
Contributor

Closing because #2974 and #2973 fix this.

@mr-c mr-c deleted the sphinx-autodoc-typehints branch November 7, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants