Skip to content

Updated tox config to run mypy in default environment#1450

Merged
nicholascar merged 1 commit intoRDFLib:masterfrom
aucampia:iwana-20211017T1353-update_tox
Dec 19, 2021
Merged

Updated tox config to run mypy in default environment#1450
nicholascar merged 1 commit intoRDFLib:masterfrom
aucampia:iwana-20211017T1353-update_tox

Conversation

@aucampia
Copy link
Member

@aucampia aucampia commented Oct 17, 2021

This is mainly so that the default tox environment mirrors the CI
checks.

Also:

  • Added some notes about tox in developers.rst.
  • Made the mypy tox environment run for all python versions.

@nicholascar
Copy link
Member

Happy for this to go through but I think we need to coordinate on our tests to remove nose, implement pytest and thus make it easier for us to fully embrace Py 3.10. This adds 3.10 build but do they actually work? As per the issue seen in #1439?

@aucampia aucampia marked this pull request as draft October 18, 2021 19:17
@aucampia
Copy link
Member Author

Marking as draft until #1439

@aucampia aucampia force-pushed the iwana-20211017T1353-update_tox branch 2 times, most recently from 3b39bce to 88f6484 Compare December 17, 2021 23:12
This is mainly so that the default tox environment mirrors the CI
checks.

Also:

* Added some notes about tox in `developers.rst`.
* Made the `mypy` tox environment run for all python versions.
@aucampia aucampia force-pushed the iwana-20211017T1353-update_tox branch from 88f6484 to 8f153f5 Compare December 17, 2021 23:13
@aucampia aucampia marked this pull request as ready for review December 17, 2021 23:14
@nicholascar nicholascar merged commit 5abe87d into RDFLib:master Dec 19, 2021
@aucampia aucampia deleted the iwana-20211017T1353-update_tox branch December 27, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants