Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 30, 2021

Bumps black from 21.7b0 to 21.8b0.

Release notes

Sourced from black's releases.

21.8b0

Black

  • Add support for formatting Jupyter Notebook files (#2357)
  • Move from appdirs dependency to platformdirs (#2375)
  • Present a more user-friendly error if .gitignore is invalid (#2414)
  • The failsafe for accidentally added backslashes in f-string expressions has been hardened to handle more edge cases during quote normalization (#2437)
  • Avoid changing a function return type annotation's type to a tuple by adding a trailing comma (#2384)
  • Parsing support has been added for unparenthesized walruses in set literals, set comprehensions, and indices (#2447).
  • Pin setuptools-scm build-time dependency version (#2457)
  • Exclude typing-extensions version 3.10.0.1 due to it being broken on Python 3.10 (#2460)

Blackd

  • Replace sys.exit(-1) with raise ImportError as it plays more nicely with tools that scan installed packages (#2440)

Integrations

  • The provided pre-commit hooks no longer specify language_version to avoid overriding default_language_version (#2430)
Changelog

Sourced from black's changelog.

21.8b0

Black

  • Add support for formatting Jupyter Notebook files (#2357)
  • Move from appdirs dependency to platformdirs (#2375)
  • Present a more user-friendly error if .gitignore is invalid (#2414)
  • The failsafe for accidentally added backslashes in f-string expressions has been hardened to handle more edge cases during quote normalization (#2437)
  • Avoid changing a function return type annotation's type to a tuple by adding a trailing comma (#2384)
  • Parsing support has been added for unparenthesized walruses in set literals, set comprehensions, and indices (#2447).
  • Pin setuptools-scm build-time dependency version (#2457)
  • Exclude typing-extensions version 3.10.0.1 due to it being broken on Python 3.10 (#2460)

Blackd

  • Replace sys.exit(-1) with raise ImportError as it plays more nicely with tools that scan installed packages (#2440)

Integrations

  • The provided pre-commit hooks no longer specify language_version to avoid overriding default_language_version (#2430)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [black](https://github.com/psf/black) from 21.7b0 to 21.8b0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](https://github.com/psf/black/commits)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 30, 2021
@nicholascar
Copy link
Member

@ashleysommer were you keen to fix on a particular version of black or are you happy to update as per this PR?

@ashleysommer
Copy link
Contributor

ashleysommer commented Sep 5, 2021

When I pinned it to 21.6b0, I think we decided that would be the last jump for a while, and we'd use that as "the black version" for rdflib.
That is what is listed as the "required-version" in black.toml so, using a newer version won't work without throwing errors.
Unfortunately it looks like someone already bumped black to 21.7b0 in requirements.dev.txt in July, so that's already broken.

@ashleysommer
Copy link
Contributor

Basically, if we ever need to bump our black version for whatever reason (security fix, major bug, etc) the steps required are:

  1. Update pinned version in requirements.dev.txt
  2. Change required-version in black.toml
  3. Update instructions in developers.rst to reflect new rdflib black version.
  4. Re-run black on all py files in ./rdflib in order to ensure they are compliant with the new version
  5. Commit all of the above changes in a single PR.
    5b) Double check drone output to ensure there's not errors thrown with new Black version in the CI run.

@nicholascar
Copy link
Member

someone already bumped black to 21.7b0 in requirements.dev.txt in July

Oops yes, that was me. It was some vague memory of that which prompted me to check now. Reverting to 21.6b0 with PR #1400

@nicholascar
Copy link
Member

Will reject dependabot black updates until the next release

@nicholascar
Copy link
Member

Closing as we will not be updating black between releases

@nicholascar nicholascar closed this Sep 5, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 5, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@nicholascar nicholascar deleted the dependabot/pip/black-21.8b0 branch September 5, 2021 22:38
@ashleysommer
Copy link
Contributor

@dependabot ignore this major version

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 5, 2021

OK, I won't notify you about version 21.x.x again, unless you re-open this PR or update to a 21.x.x release yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants