Replace Sleepycat with BerkeleyDB#1347
Merged
nicholascar merged 36 commits intomasterfrom Jul 2, 2021
Merged
Conversation
added 30 commits
April 24, 2021 20:59
…ile docco error, fixed parse() for Dataset/ConGr
added 2 commits
June 27, 2021 23:45
…eydb # Conflicts: # docs/intro_to_sparql.rst # examples/conjunctive_graphs.py # examples/simple_example.py # examples/sleepycat_example.py # tox.ini
Member
Author
|
I'll wait until the other PRs improving the address assigning issue in tests are merged before re-submitting this to test so hopefully it passes everything then. |
Member
|
Sorry, for coming in late. But I'm unsure, if it is a good idea to change old entries in the changelog (e.g. 2011/03/17). Why do you think it is good to replace sleepycat with berkeleydb in the old entries? I think an entry, that states that sleepycat was renamed to berkeleydb in the latest changelog entry would do the trick. |
Member
Author
|
I think you’re right: I probably accidentally renamed Sleepycat here when I did a find and replace. I’ll name it back |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
bsddb3module withberkeleydb, as recommended for Python 3.6+ and replaces all references to 'Sleepycat' with 'BerkeleyDB'. Updates store name, documentation and examples. Also provides tests.