fix: solve error with anchor without href

[franpeza]

What is it?

• Feature / enhancement
• Bug
• Docs / tests

Description

An error is thrown when trying to access a property of an anchor element that hasn't been set an href. This PR fixes this issue handling the scenario and returning an appropriate value depending on the property accessed.

This is how the error looks like:

Checklist:

• My code follows the developer guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• Added new tests to cover the fix / functionality

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
partytown	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 29, 2023 0:13am

[SirJalias]

Hello
I consider this PR might help fix some issues reported like #476 #482 and possibly #519.
We were implementing partytown to run our GTM scripts though the web worker, but depending on the environment was working, for example in the pre-prod environment GA4 events are sent but in the prod environment there is no event sent to GA4, debugging the gtag.js script we detected that on production the GA4 scripts was failing ( silently ) , any of you having issues with GA4 can set a breakpoint here in the gtag.js here:

 catch ($I) {
            a.s.onFailure()
        }

The error , on our case, is:

TypeError: Failed to construct 'URL': Invalid URL
at E.get (126814e7-b6fb-4aa6-99f0-bae5f303fc6e:2:13380)

So, digging a bit deeper we detected the issue was coming from this part of the gtag.js script:

Hn = function(a) {
        var b = E.createElement("a");
        a && (b.href = a);
        var c = b.pathname;
        "/" !== c[0] && (a || Ab("TAGGING", 1),
        c = "/" + c);
        var d = b.hostname.replace(An, "");
        return {
            href: b.href,
            protocol: b.protocol,
            host: b.host,
            hostname: d,
            pathname: c,
            search: b.search,
            hash: b.hash,
            port: b.port
        }

So would be great to have this MR merged the sooner the better !
Thank you @franpeza !

[gioboa]

Thanks @franpeza for this PR
@SirJalias 👏 you did a great recap

[gioboa]

@SirJalias did you figure out why gtag is adding an empty anchor ?

[franpeza]

We tried to debug the code but it was so difficult to follow the execution since it's minified, so we are not sure actually 🥲

[gioboa]

Thanks for your amazing help @franpeza

[franpeza]

hello @gioboa and thanks for merging this PR. Do you have an estimate of when there will be a new version that includes these changes? Thanks :)

[franpeza]

by the way, and after digging into the open issues, this should solve #189 too

[gioboa]

by the way, and after digging into the open issues, this should solve #189 too

Thanks 😊

hello @gioboa and thanks for merging this PR. Do you have an estimate of when there will be a new version that includes these changes? Thanks :)

I'll ping the core team, we have few improvements to publish 🚀