Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add image.removeEventListener implementation #500

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

esjs
Copy link
Contributor

@esjs esjs commented Nov 16, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

removeEventListener is missing on internal Image implementation, which can cause errors in some scenarios.
image-remove-event-listener

Use cases and why

Well, it's part of the spec, so it would be great if Partytown correctly handles this.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 9:42am

@gioboa gioboa changed the title Add missing implementation for image.removeEventListener feat: add image.removeEventListener implementation Jan 7, 2024
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @esjs you rock

@gioboa gioboa merged commit 606dc36 into QwikDev:main Jan 7, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants