Conversation
Signed-off-by: QwertyJack <7554089+QwertyJack@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the Developer Certificate of Origin (DCO) file, changing the version from "1.1" to "1.x". My review identifies a critical issue with this change. The DCO text itself, on line 7, prohibits modifications. This change violates that term and also creates an inconsistency with line 10 of the same document. I have recommended reverting this change to maintain the legal integrity of the DCO.
| @@ -1,5 +1,5 @@ | |||
| Developer Certificate of Origin | |||
| Version 1.1 | |||
| Version 1.x | |||
There was a problem hiding this comment.
The Developer Certificate of Origin (DCO) is a standard legal text that should not be modified. Line 7 of this document explicitly states: "Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed." Modifying the version from "1.1" to "1.x" violates this clause.
Furthermore, this change introduces an inconsistency, as line 10 still refers to "Developer's Certificate of Origin 1.1". To maintain the legal integrity of the DCO, the original, unmodified text should be restored.
Version 1.1
QwertyJack
force-pushed
the
main
branch
12 times, most recently
from
d3c8536 to
7a1ee43
Compare
…-project#6738) ### What this PR does / why we need it? **Scope of Changes**: | File Path | | :--- | | `tests/e2e/310p/multicard/test_vl_model_multicard.py` | | `tests/e2e/310p/singlecard/test_vl_model_singlecard.py` | | `tests/e2e/310p/test_utils.py` | | `tests/e2e/conftest.py` | | `tests/e2e/model_utils.py` | | `tests/e2e/models/conftest.py` | | `tests/e2e/models/test_lm_eval_correctness.py` | | `tests/e2e/multicard/2-cards/spec_decode/test_spec_decode.py` | | `tests/e2e/multicard/2-cards/test_aclgraph_capture_replay.py` | | `tests/e2e/multicard/2-cards/test_data_parallel.py` | | `tests/e2e/multicard/2-cards/test_disaggregated_encoder.py` | | `tests/e2e/multicard/2-cards/test_expert_parallel.py` | | `tests/e2e/multicard/2-cards/test_external_launcher.py` | | `tests/e2e/multicard/2-cards/test_full_graph_mode.py` | | `tests/e2e/multicard/2-cards/test_ilama_lora_tp2.py` | | `tests/e2e/multicard/2-cards/test_offline_inference_distributed.py` | | `tests/e2e/multicard/2-cards/test_offline_weight_load.py` | | `tests/e2e/multicard/2-cards/test_pipeline_parallel.py` | | `tests/e2e/multicard/2-cards/test_prefix_caching.py` | | `tests/e2e/multicard/2-cards/test_quantization.py` | | `tests/e2e/multicard/2-cards/test_qwen3_moe.py` | | `tests/e2e/multicard/2-cards/test_qwen3_moe_routing_replay.py` | | `tests/e2e/multicard/2-cards/test_qwen3_performance.py` | | `tests/e2e/multicard/2-cards/test_shared_expert_dp.py` | | `tests/e2e/multicard/2-cards/test_single_request_aclgraph.py` | | `tests/e2e/multicard/2-cards/test_sp_pass.py` | ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@9562912 Signed-off-by: MrZ20 <2609716663@qq.com> Co-authored-by: wangxiyuan <wangxiyuan1007@gmail.com>
1 participant
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?