Repository navigation
feat(web-shell): add opt-in interactive browser terminal #9984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8364f8c
feat(web-shell): add opt-in interactive browser terminal
14995bf
Merge remote-tracking branch 'origin/main' into worktree-terminal-panel
e009472
Merge branch 'main' into worktree-terminal-panel
ytahdn f5819dc
chore(vscode): update third-party notices
10f088e
test(cli): include web terminal capability
c0114c0
test(integration): include web terminal capability
50a15d0
fix(web-shell): harden terminal lifecycle
dec726f
Merge branch 'main' into worktree-terminal-panel
ytahdn 161b7bd
Merge remote-tracking branch 'origin/main' into worktree-terminal-panel
36f7c43
docs(serve): document web terminal capability
759ac96
Merge remote-tracking branch 'origin/main' into worktree-terminal-panel
fdb8fbe
Merge branch 'main' into worktree-terminal-panel
wenshao cc54771
fix(web-shell): address terminal review findings
4b1f855
fix(web-shell): address terminal review findings
2dac41c
Merge branch 'main' into worktree-terminal-panel
ytahdn f41be7b
fix(web-shell): preserve terminal sessions and key events
7dca447
fix(web-shell): harden terminal session cleanup
c36212e
fix(web-shell): make terminal limits recoverable
34a5b0a
fix(web-shell): isolate terminal sessions
4960873
Merge branch 'main' into worktree-terminal-panel
ytahdn 72d611b
Merge branch 'main' into worktree-terminal-panel
ytahdn da212e5
Merge branch 'main' into worktree-terminal-panel
wenshao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Web terminal lifecycle | ||
|
|
||
| The browser terminal is a manually opened Web Shell surface. The host must add | ||
| the terminal right-panel action and the daemon must advertise the | ||
| `web_terminal` capability before the UI exposes the entry. WebSocket requests | ||
| use the daemon's shared Host, Origin, authentication and workspace trust gates. | ||
|
|
||
| Each terminal is owned by one active, trusted workspace runtime. The daemon | ||
| resolves the client workspace selector against the live registry and supplies | ||
| that runtime's cwd and effective environment to the PTY. A terminal id cannot | ||
| be reclaimed through another workspace. | ||
|
|
||
| Closing a terminal tab sends an explicit release control frame and kills the | ||
| PTY. Hiding the panel, switching tabs or losing the WebSocket only detaches the | ||
| client, so reconnect can replay the same session. A detached session is killed | ||
| after the idle timeout even if its command is still running. Exited sessions | ||
| replay both scrollback and exit state. Binary WebSocket frames contain UTF-8 | ||
| terminal input and output; NUL-prefixed text frames contain control messages. | ||
| Reloading the page loses the in-memory terminal id, so the detached session is | ||
| reclaimed after the idle timeout rather than restored into the new page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.