-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(webui): hydrate Goal independently of session metadata #9977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+134
−30
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The guard here changed from
sessionRef.current !== activeSessionto(sessionRef.current !== undefined && sessionRef.current !== activeSession).The new form allows the final
setConnectionto proceed whensessionRef.currentisundefined— which happens during a state resync (handleStateResyncat ~line 2547 setssessionRef.current = undefinedwhile keeping the samesessionId). In that window, the old guard would have blocked this update; the new guard does not, so the load's final commit can setstatus: \'connected\'andloadingTranscript: undefinedover the resync'sstatus: \'connecting\'.Is this intentional? If the resync overlaps with a metadata load, the metadata from the original load should still be valid (same session), so proceeding seems reasonable. I want to confirm that the
abort.signal.abortedcheck is sufficient to catch the cases where proceeding would be wrong.