Repository navigation
fix(core): accept contained symlinks in the older-Git archive fallback #9969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wenshao
merged 19 commits into
QwenLM:main
from
harjothkhara:fix/9724-safe-archive-symlinks
Aug 29, 2026
Merged
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ad75c92
fix(core): accept contained symlinks in the older-Git archive fallback
harjothkhara 008c94c
fix(core): harden contained symlink validation
harjothkhara 0bb7337
test(core): pin post-flatten symlink validation
harjothkhara 4ecfb52
fix(core): reject post-extraction symlink chains
harjothkhara c54eafb
fix(core): enforce materialized archive size
harjothkhara c4a23fd
fix(core): validate final archive layout exactly
harjothkhara 7ae9f97
fix(core): bound archive path validation
harjothkhara 7a800e9
fix(core): reject unresolved archive targets
harjothkhara 2135c75
fix(core): canonicalize archive entry separators
harjothkhara d707895
test(core): cover symlink descendant extraction
harjothkhara e1c29cf
fix(core): reject ambiguous symlink targets
harjothkhara 83dc67c
fix(core): wrap archive layout errors
harjothkhara 640d8e2
fix(core): preserve validated plugin symlinks
harjothkhara 2b3cafd
fix(core): reject root-normalized link entries
harjothkhara 6d5ae8c
fix(core): close archive-safety review-round-3 gaps
harjothkhara 3e2f352
fix(core): re-validate symlinks when conversion moves the archive-val…
harjothkhara 2340e39
Merge branch 'main' into fix/9724-safe-archive-symlinks
wenshao 5f22a62
fix(core): make the post-conversion symlink re-validation guard reach…
harjothkhara e0e6530
test(core): fix round-5 review gaps in the re-validation guard's tests
harjothkhara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retargeted both tests at inputs that actually reach their named clause — verified by mutation (deleting the ancestor clause now fails the ancestor test). The self-reference clause turned out to be structurally unreachable as a deciding factor: onReadEntry always records the entry itself in
archiveEntries(typed SymbolicLink) before this check runs, so a link naming itself is always caught by the post-loop "target must be a distinct regular-file entry" scan regardless of this clause. Left a comment on that test explaining why it can't be made discriminating rather than claim it is.