Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 123 additions & 0 deletions packages/cli/src/commands/review/parse-args.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,116 @@ describe('parseReviewArgs — --severity-floor (the convergence posture knob)',
});
});

describe('parseReviewArgs — --topology (the minimal-prompt A/B arm)', () => {
it('defaults to auto: the standing effort-driven pipeline', () => {
const got = parseReviewArgs('6711');
expect(got.topology).toBe('auto');
expect(got.topologySource).toBe('default');
});

it('parses both forms case-insensitively; the last valid occurrence wins', () => {
expect(parseReviewArgs('6711 --topology minimal')).toMatchObject({
topology: 'minimal',
topologySource: 'explicit',
});
expect(parseReviewArgs('6711 --topology=Minimal')).toMatchObject({
topology: 'minimal',
});
expect(
parseReviewArgs('6711 --topology minimal --topology auto'),
).toMatchObject({ topology: 'auto', topologySource: 'explicit' });
});

it('an explicit --topology auto is explicit, not the default', () => {
const got = parseReviewArgs('6711 --topology auto');
expect(got.topology).toBe('auto');
expect(got.topologySource).toBe('explicit');
});

it('selecting minimal does not change the target', () => {
expect(parseReviewArgs('6711 --topology minimal').target).toEqual({
type: 'pr-number',
number: 6711,
});
expect(parseReviewArgs('src/foo.ts --topology minimal').target).toEqual({
type: 'file',
path: 'src/foo.ts',
});
});

it('minimal gates --comment: terminal-only, posts nothing', () => {
const got = parseReviewArgs('6711 --topology minimal --comment');
expect(got.comment.requested).toBe(true);
expect(got.comment.effective).toBe(false);
expect(
got.warnings.some(
(w) => w.includes('`--comment`') && w.includes('terminal-only'),
),
).toBe(true);
});

it('minimal gates --fix: terminal-only, edits nothing', () => {
const got = parseReviewArgs('src/foo.ts --topology minimal --fix');
expect(got.fix.requested).toBe(true);
expect(got.fix.effective).toBe(false);
expect(
got.warnings.some(
(w) => w.includes('`--fix`') && w.includes('terminal-only'),
),
).toBe(true);
});

it('an invalid value warns naming what is in effect, and never eats the target', () => {
const got = parseReviewArgs('--topology minial 6711');
expect(got.target).toEqual({ type: 'pr-number', number: 6711 });
expect(got.topology).toBe('auto');
expect(
got.warnings.some(
(w) =>
w.includes('Invalid --topology value "minial"') &&
w.includes('default topology'),
),
).toBe(true);
});

it('an invalid equals-form value warns instead of vanishing', () => {
const got = parseReviewArgs('6711 --topology=minial');
expect(got.target).toEqual({ type: 'pr-number', number: 6711 });
expect(got.topology).toBe('auto');
expect(
got.warnings.some((w) => w.includes('Invalid --topology value "minial"')),
).toBe(true);
});

it('a sole invalid value becomes the target, and the warning says so', () => {
const got = parseReviewArgs('--topology minial');
expect(got.target).toEqual({ type: 'file', path: 'minial' });
expect(
got.warnings.some(
(w) =>
w.includes('Invalid --topology value "minial"') &&
w.includes('treating it as the review target'),
),
).toBe(true);
});

it('a PR-shaped value is rescued as the target, not discarded', () => {
// `--topology 6711` (forgot the value) must review PR 6711, not silently
// fall back to the local diff — the same rescue --effort/--severity-floor get.
const got = parseReviewArgs('--topology 6711');
expect(got.target).toEqual({ type: 'pr-number', number: 6711 });
expect(got.topology).toBe('auto');
});

it('minimal does not force effort the way --comment does', () => {
// minimal is terminal-only, so the comment-forces-high rule never fires;
// a local target's effort stays at its default.
const got = parseReviewArgs('src/foo.ts --topology minimal');
expect(got.effort).toBe('medium');
expect(got.effortSource).toBe('default');
});
});

describe('parseReviewArgs — settings-provided defaults', () => {
it('applies the configured effort when --effort is absent', () => {
const got = parseReviewArgs('6711', { effort: 'medium' });
Expand Down Expand Up @@ -1155,6 +1265,19 @@ describe('parseArgsCommand wiring', () => {
expect(written).toBe(String(vi.mocked(writeStdoutLine).mock.calls[0][0]));
});

it('--topology minimal survives the stdin → yargs → handler path', async () => {
// The flag must reach the printed verdict through the real handler, not
// just the pure function: a wiring drop leaves every pure-function test
// green while real `/review … --topology minimal` runs the full pipeline.
fsState.stdin = '6711 --topology minimal --comment\n';
await runCli(['parse-args', '--stdin']);
const got = printedVerdict();
expect(got.target).toEqual({ type: 'pr-number', number: 6711 });
expect(got.topology).toBe('minimal');
expect(got.topologySource).toBe('explicit');
expect(got.comment).toEqual({ requested: true, effective: false });
});

// The real CLI nests this command under `review`, which changes what
// yargs puts in argv._ (['review', 'parse-args'] instead of
// ['parse-args']) — the smuggle guard once read that command path as
Expand Down
141 changes: 136 additions & 5 deletions packages/cli/src/commands/review/parse-args.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,20 @@ export type ReviewEffort = 'low' | 'medium' | 'high';
*/
export type ReviewSeverityFloor = 'critical' | 'suggestion';

/**
* The review topology: which shape the run takes. `auto` is the standing
* effort-driven pipeline (the 3A/3B/3C fan-outs). `minimal` is the A/B
* comparison arm from issue #9783 — a single careful senior-engineer pass
* over the diff in the orchestrator's own context, at most fifteen findings,
* each carrying a concrete failure scenario; no subagent fan-out, no
* verification, no reverse audit, no posting. It exists so the full pipeline
* and the minimal prompt can be run over the same PR set and compared per
* model. It is deliberately orthogonal to `effort` — it is a different
* _shape_ of review, not a depth of the same one — and selecting it skips the
* agent machinery (roster, coverage, budget) entirely rather than shrinking it.
*/
export type ReviewTopology = 'auto' | 'minimal';

export type ReviewTarget =
| { type: 'pr-number'; number: number }
| {
Expand Down Expand Up @@ -111,6 +125,13 @@ export interface ParsedReviewArgs {
*/
severityFloor: ReviewSeverityFloor | 'auto';
severityFloorSource: 'explicit' | 'configured' | 'default';
/**
* The review topology. `auto` (the default) runs the standing effort-driven
* pipeline; `minimal` runs the single-pass A/B arm and, because it neither
* posts nor edits, forces `comment.effective` and `fix.effective` to false.
*/
topology: ReviewTopology;
topologySource: 'explicit' | 'default';
/** The `--host` flag's value, when present — recorded verbatim so the
* write gate can bind a recorded bare-number target's platform (the
* target itself carries no host in that spelling). */
Expand Down Expand Up @@ -156,6 +177,14 @@ export const SEVERITY_FLOORS: ReadonlySet<string> = new Set([
'auto',
]);

export const TOPOLOGIES: ReadonlySet<string> = new Set([
'minimal',
// `auto` is a legal EXPLICIT value for the same reason it is for
// `--severity-floor`: typing `--topology auto` means "the standing
// effort-driven pipeline", not a typo to reject.
'auto',
]);

// The verdict's owner/repo/number are interpolated into `gh` commands by the
// caller, so they must be established trustworthily, not merely extracted:
// the scheme is case-insensitive, the number must END at the path segment
Expand Down Expand Up @@ -202,6 +231,11 @@ function asSeverityFloor(value: string): ReviewSeverityFloor | 'auto' | null {
: null;
}

function asTopology(value: string): ReviewTopology | null {
const lower = value.toLowerCase();
return TOPOLOGIES.has(lower) ? (lower as ReviewTopology) : null;
}

/**
* Single-dash tokens count as flags too: `-c` is never a plausible review
* target, and classifying it as a file path demoted the real target the
Expand Down Expand Up @@ -336,6 +370,7 @@ export function parseReviewArgs(
let resumeRequested = false;
let explicitEffort: ReviewEffort | null = null;
let explicitFloor: ReviewSeverityFloor | 'auto' | null = null;
let explicitTopology: ReviewTopology | null = null;
let recordedHostFlag: string | undefined;

// The configured default gets the same validation as an explicit flag:
Expand Down Expand Up @@ -384,6 +419,8 @@ export function parseReviewArgs(
// deferred-warning problem; its issues are a separate list because its
// resolution sentence is its own.
const floorIssues: EffortIssue[] = [];
// `--topology` shares the value-token grammar too, for the same reason.
const topologyIssues: EffortIssue[] = [];

// First pass: pull out flags (and each value-taking flag's value token,
// when the spaced form legitimately consumes one). Non-flag tokens are kept
Expand All @@ -392,7 +429,7 @@ export function parseReviewArgs(
interface Kept {
token: string;
/** Set when this token arrived as an invalid value of the named flag. */
invalidValueOf?: '--effort' | '--severity-floor';
invalidValueOf?: '--effort' | '--severity-floor' | '--topology';
}
const kept: Kept[] = [];

Expand Down Expand Up @@ -510,6 +547,40 @@ export function parseReviewArgs(
continue;
}

if (token === '--topology' || token.startsWith('--topology=')) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred to the next round, not declined — this round ran under a budget warning and was scoped to the two Critical findings only, and this one is a refactor (~34-line grammar extraction across three flags plus unifying three deferred-warning switches). The finding is acknowledged as real: --topology is a near-verbatim third copy of the value-token grammar, and the module's own comments record grammar bug-fixes that had to be replicated across every copy. The extraction into one shared helper + composeIssueWarnings is queued for the next round, where it can get its own verification pass.

中文说明

推迟到下一轮,并非拒绝——本轮在预算警告下运行,范围被限定为仅处理两条 Critical 发现,而本条是一次重构(跨三个 flag 提取约 34 行的值 token 语法,并统一三个延迟警告 switch)。该发现被承认为真实:--topology 是值 token 语法的第三份近乎逐字的拷贝,模块自身的注释也记录了每次语法修复都必须在所有拷贝中复制的历史。抽成一个共享助手函数 + composeIssueWarnings 已排入下一轮,届时可以有自己独立的验证过程。

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred to the next round. The extraction is the right fix, but it is this batch's largest change — ~90 lines of churn across three hardened copies of the value-token grammar that carry four documented grammar-fix rounds — and this round already carries the Critical (R1-10) plus seven other findings, at the ~8-finding batch bound. De-risking for it landed this round: the three --topology grammar branches that had no witnesses (equals-form PR-shaped rescue, quoted-empty consumption, flag-final/flag-followed missing value) are now pinned by sibling-mirroring probes in the --topology describe, so the helper refactor lands against full branch coverage and any divergence fails loudly.

中文说明

延至下一轮处理。抽取助手函数是正确的修复方向,但它是本批中最大的改动——约 90 行的改动横跨值-令牌语法的三份已加固拷贝(各有四份有据可查的语法修复记录)——而本轮已承载 Critical(R1-10)加另外七条发现,达到每轮约 8 条的批次上限。本轮已为其提前降低风险:原先没有证据的三个 --topology 语法分支(等号形态的 PR 形状救援、引号空值消耗、标志结尾/标志跟随的缺值分支)现在已由 --topology describe 中镜像兄弟标志的探针钉住,因此助手函数重构将在完整的分支覆盖下落地,任何分歧都会大声失败。

if (token.includes('=')) {
const value = token.slice(token.indexOf('=') + 1);
const topologyValue = asTopology(value);
if (topologyValue !== null) {
explicitTopology = topologyValue;
} else if (value !== '' && isPrShapedToken(value)) {
kept.push({ token: value, invalidValueOf: '--topology' });
} else {
topologyIssues.push({ kind: 'invalid-eq', value });
}
continue;
}
const next = i + 1 < tokens.length ? tokens[i + 1] : undefined;
const nextTopology = next !== undefined ? asTopology(next) : null;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred to the next round, not declined — this round ran under a budget warning and was scoped to the two Critical findings only. The finding is acknowledged as real (with its corrected note that the discarded kind is already covered): the --topology missing-value paths — flag-final, flag-followed-by-flag, quoted-empty consumption, empty equals-form — have zero tests while both sibling flags test all of them, and the measured mutants survive the suite. Extending the existing missing-value tests to --topology is queued for the next round.

中文说明

推迟到下一轮,并非拒绝——本轮在预算警告下运行,范围被限定为仅处理两条 Critical 发现。该发现被承认为真实(包括其修正说明:discarded 种类已有覆盖):--topology 的缺值路径——flag 位于末尾、flag 后紧跟 flag、引号空值吞噬、空的等号形态——一个测试都没有,而两个兄弟 flag 对这些形态都有测试,且实测突变体在整个套件中存活。把既有的缺值测试扩展到 --topology 已排入下一轮。

if (nextTopology !== null) {
explicitTopology = nextTopology;
i++;
continue;
}
if (next === '') {
topologyIssues.push({ kind: 'missing' });
i++;
continue;
}
if (next === undefined || isFlag(next)) {
topologyIssues.push({ kind: 'missing' });
continue;
}
kept.push({ token: next, invalidValueOf: '--topology' });
i++;
continue;
}

if (isFlag(token)) {
unknownFlags.push(token);
warnings.push(`Unrecognized flag ${JSON.stringify(token)}; ignored.`);
Expand Down Expand Up @@ -652,7 +723,12 @@ export function parseReviewArgs(
: undefined;
let rescuedPr = false;
for (const k of kept) {
const issues = k.invalidValueOf === '--effort' ? effortIssues : floorIssues;
const issues =
k.invalidValueOf === '--effort'
? effortIssues
: k.invalidValueOf === '--severity-floor'
? floorIssues
: topologyIssues;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred to the next round, not declined — this round ran under a budget warning and was scoped to the two Critical findings only. The finding is acknowledged as real: the rescue loop's flag→issue-list ternary ends in an else that makes topologyIssues the silent catch-all for any future invalidValueOf union member, with no exhaustiveness check. The suggested exhaustive Record<NonNullable<Kept['invalidValueOf']>, EffortIssue[]> mapping is queued for the next round.

中文说明

推迟到下一轮,并非拒绝——本轮在预算警告下运行,范围被限定为仅处理两条 Critical 发现。该发现被承认为真实:救援循环里 flag→issue 列表的三元链以 else 收尾,使 topologyIssues 成为未来任何 invalidValueOf 联合成员的静默兜底,且没有穷尽性检查。建议中的穷尽式 Record<NonNullable<Kept['invalidValueOf']>, EffortIssue[]> 映射已排入下一轮。

if (k.invalidValueOf !== undefined) {
const survives = isPrShaped(k.token)
? !hasValidCandidate && distinctPr.size === 1
Expand Down Expand Up @@ -732,12 +808,30 @@ export function parseReviewArgs(

const isPr = target.type === 'pr-number' || target.type === 'pr-url';

// The topology resolves like the effort — an explicit flag beats the
// standing `auto` default. There is no configured (settings) topology: the
// minimal arm is an explicit A/B comparison, never a background default.
const topology: ReviewTopology = explicitTopology ?? 'auto';
const topologySource: ParsedReviewArgs['topologySource'] =
explicitTopology !== null ? 'explicit' : 'default';
// The minimal arm is terminal-only — it neither posts to a PR nor edits a
// working tree — so both write operations are gated off it. This keeps the
// guarantee in code rather than in whichever prose the orchestrator reads.
const isMinimal = topology === 'minimal';

const commentRequested = commentRequestedByFlag || defaults.comment === true;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred to the next round, not declined — this round ran under a budget warning and was scoped to the two Critical findings only. The finding is acknowledged as real: no test crosses a settings-provided comment: true with --topology minimal, and the measured mutant that lets a settings-driven comment bypass the minimal gate survives the suite and would open the posting gate in lib/authorization.ts. Adding parseReviewArgs('6711 --topology minimal', { comment: true }) asserting comment: {requested: false, effective: false} plus the warning is queued for the next round.

中文说明

推迟到下一轮,并非拒绝——本轮在预算警告下运行,范围被限定为仅处理两条 Critical 发现。该发现被承认为真实:没有任何测试把设置提供的 comment: true 与 --topology minimal 组合起来,且实测中让设置驱动的 comment 绕过 minimal 门控的突变体在整个套件中存活,并会打开 lib/authorization.ts 的发布门控。补一个断言 comment: {requested: false, effective: false} 与警告的 parseReviewArgs('6711 --topology minimal', { comment: true }) 已排入下一轮。

const commentEffective = commentRequested && isPr;
const commentEffective = commentRequested && isPr && !isMinimal;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred to the next round, not declined — this round ran under a budget warning and was scoped to the two Critical findings only. The finding is acknowledged as real: the write-authorization refusal why in lib/authorization.ts composes only the two pre-existing causes of comment.effective === false, so a minimal run is refused with the factually wrong "do not name a pull request" reason while the real blocker (--topology minimal is terminal-only) goes unnamed. The fix is the suggested topology === 'minimal' branch ahead of the existing arms; it is queued for the next round.

中文说明

推迟到下一轮,并非拒绝——本轮在预算警告下运行,范围被限定为仅处理两条 Critical 发现。该发现被承认为真实:lib/authorization.ts 的写授权拒绝理由只根据 comment.effective === false 的既有两个成因拼装,于是 minimal 运行会收到与事实不符的「没有指定 pull request」理由,而真正的阻塞原因(--topology minimal 仅终端输出)从未被点名。修复方案即建议中的在既有分支之前增加 topology === 'minimal' 分支;已排入下一轮。

if (commentRequestedByFlag && !isPr) {
warnings.push(
'Warning: `--comment` flag is ignored because the review target is not a PR.',
);
} else if (commentRequested && isPr && isMinimal) {
// Only when minimal is THE reason a would-be-effective comment is
Comment on lines +853 to +854

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred to the next round, not declined — this round ran under a budget warning (the previous round exhausted its time budget) and was scoped to the two Critical findings only. The finding is acknowledged as real: the minimal-topology comment warning fires on commentRequested (flag OR setting) but always names the --comment flag, contradicting comment.requested: false when the request came from review.comment: true. The fix is the suggested flag-vs-setting split mirroring the sibling forced-effort warning; it is queued for the next round.

中文说明

推迟到下一轮,并非拒绝——本轮在预算警告下运行(上一轮耗尽了时间预算),范围被限定为仅处理两条 Critical 发现。该发现被承认为真实:minimal 拓扑的 comment 警告基于 commentRequested(flag 或设置)触发,但文案始终点名 --comment flag,当请求实际来自 review.comment: true 时与 comment.requested: false 自相矛盾。修复方案即建议中的仿照兄弟强制 effort 警告、区分 flag 与设置来源的写法;已排入下一轮。

// suppressed: on a non-PR target the comment does not apply anyway, and
// that case keeps its usual handling above.
warnings.push(
'Warning: `--comment` is ignored because `--topology minimal` is terminal-only — the minimal arm posts nothing.',
);
}

const resumeEffective = resumeRequested && isPr;
Expand All @@ -750,13 +844,17 @@ export function parseReviewArgs(
// `--fix` edits a working tree, so it needs one that outlives the review. A
// PR review's tree is the ephemeral worktree Step 9 removes; a `local` or
// `file` review's tree is the user's own checkout.
const fixEffective = fixRequested && !isPr;
const fixEffective = fixRequested && !isPr && !isMinimal;
if (fixRequested && isPr) {
warnings.push(
'Warning: `--fix` flag is ignored because a PR review runs in an ephemeral ' +
'worktree that is deleted when the review ends — there is no durable tree to ' +
'fix. Use `--comment` to publish the findings instead.',
);
} else if (fixRequested && isMinimal) {
warnings.push(
'Warning: `--fix` is ignored because `--topology minimal` is terminal-only — the minimal arm edits nothing.',
);
}

let effort: ReviewEffort;
Expand Down Expand Up @@ -900,6 +998,37 @@ export function parseReviewArgs(
);
}

// The topology's deferred warnings, composed now that the resolution is
// final — the same shape as the effort's and the floor's.
const topologyResolution =
topologySource === 'explicit'
? `--topology ${topology} (the last valid occurrence) is in effect`
: 'using the default topology (auto)';
for (const issue of topologyIssues) {
switch (issue.kind) {
case 'invalid-eq':
warnings.push(
`Invalid --topology value ${JSON.stringify(issue.value)}; ${topologyResolution}.`,
);
break;
case 'missing':
warnings.push(`--topology requires a value; ${topologyResolution}.`);
break;
case 'discarded':
warnings.push(
`Invalid --topology value ${JSON.stringify(issue.value)} discarded; ${topologyResolution}.`,
);
break;
case 'kept-as-target':
warnings.push(
`Invalid --topology value ${JSON.stringify(issue.value)}; treating it as the review target — ${topologyResolution}.`,
);
break;
default:
break;
}
}

return {
target,
effort,
Expand All @@ -908,6 +1037,8 @@ export function parseReviewArgs(
fix: { requested: fixRequested, effective: fixEffective },
severityFloor,
severityFloorSource,
topology,
topologySource,
...(recordedHostFlag !== undefined ? { host: recordedHostFlag } : {}),
resume: { requested: resumeRequested, effective: resumeEffective },
extraTokens,
Expand Down Expand Up @@ -954,7 +1085,7 @@ function reviewDefaultsFromSettings(): {
export const parseArgsCommand: CommandModule = {
command: 'parse-args [raw]',
describe:
'Parse the /review skill argument string (--comment, --fix, --resume, --effort, --severity-floor, target disambiguation) and emit the verdict as JSON; pass the string on stdin via --stdin (a positional that begins with a dash never reaches this handler — yargs rejects it as an unknown flag)',
'Parse the /review skill argument string (--comment, --fix, --resume, --effort, --severity-floor, --topology, target disambiguation) and emit the verdict as JSON; pass the string on stdin via --stdin (a positional that begins with a dash never reaches this handler — yargs rejects it as an unknown flag)',
builder: (yargs) =>
yargs
.positional('raw', {
Expand Down
2 changes: 2 additions & 0 deletions packages/core/src/skills/bundled/review/DESIGN.md
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,8 @@ The countermeasure is cheap and needs no new machinery: before Step 4, sanity-ch

## LLM call budget

**`--topology minimal` — 0 subagent calls.** The minimal arm (issue #9783, Step 3M) is a single careful pass over the diff in the orchestrator's own context — no fan-out, no verification, no reverse audit, no build/test. It costs one model turn, the same shape as the low tier's inline pass, and it is priced here for completeness, not as a recommended default: it exists so the full pipeline and this minimal prompt can be run over the same PR set and compared per model. This section tracks per-topology _cost_; the A/B the minimal arm enables extends it with per-model _quality_, which is what decides whether any cell of a future model-family × effort routing table routes away from the full pipeline. Until that data exists, every review runs the topology below.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred to the next round, not declined — this round ran under a budget warning and was scoped to the two Critical findings only. The finding is acknowledged as real: the minimal arm shares all three properties the prose reserves for low, but docs/users/features/code-review.md ("Only low is unverified") and DESIGN.md's guardrails scope sentence ("means low alone") still enumerate a one-member set, and the docs page omits --topology entirely. Correcting both enumerations and adding a short --topology minimal docs section is queued for the next round.

中文说明

推迟到下一轮,并非拒绝——本轮在预算警告下运行,范围被限定为仅处理两条 Critical 发现。该发现被承认为真实:minimal 臂具备文案保留给 low 的全部三个属性,但 docs/users/features/code-review.md(「Only low is unverified」)与 DESIGN.md 的 guardrails 范围句(「means low alone」)仍说这个集合只有一个成员,且文档页完全没有提及 --topology。修正两处枚举并为 --topology minimal 增加一小节文档已排入下一轮。


**Small diffs (≤ 500 source lines AND ≤ 3200 total diff lines, Step 3A, high effort) — 17-28 calls (typically 17-19):**

| Stage | Calls | Why |
Expand Down
Loading
Loading