-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(cli): Recover sessions across archive races #9513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
6184588
fix(cli): report a conversation directory deleted mid-inspection as a…
doudouOUC 8663769
fix(cli): keep conversation metadata reads race-free and parent ids s…
doudouOUC 967ebf5
fix(core): let loads resolve both-states sessions and drop the pre-lo…
doudouOUC c6cab84
fix(cli): preserve canonical restore conflicts
doudouOUC 5d989b0
fix(serve): handle case-variant session follow-ups
doudouOUC a850de9
fix(serve): preserve mixed-case live task identity
doudouOUC 4b0ead7
fix(serve): resolve canonical persisted session ids
doudouOUC b5590d5
fix(serve): preserve canonical session restore state
doudouOUC 9878101
fix(serve): complete canonical session reads
doudouOUC c708a2b
fix(serve): address canonical review findings
doudouOUC cfe8501
fix(serve): preserve aliased session organization
doudouOUC f0bdf6b
fix(serve): close canonical session review gaps
doudouOUC e948683
fix(serve): close canonical task ownership gaps
doudouOUC cde0d99
chore: merge origin/main into #9513
doudouOUC c3406cd
fix(serve): keep case twins distinct across session pages
doudouOUC 4dee4ac
fix(serve): isolate alias verification failures
doudouOUC bac7f15
test(integration): align both-states transcript expectation
doudouOUC 4bfb350
fix(cli): preserve mixed-case session ownership
doudouOUC 212aed5
fix(cli): preserve live task ownership during refresh
doudouOUC b318cda
fix(serve): handle session alias races
doudouOUC 561b297
codex: address PR review feedback (#9513)
doudouOUC b9ae2f6
test(e2e): normalize generated session ids
doudouOUC 5517d23
Merge remote-tracking branch 'origin/main' into codex/pr9513-rebuilt-…
doudouOUC f69edcf
fix(cli): narrow PR 9513 to restore regressions
doudouOUC 03f1dcb
fix(cli): complete active transcript conflict recovery
doudouOUC 88fddbe
test(cli): align session conflict assertions
doudouOUC de45968
test(cli): align transcript conflict e2e
doudouOUC 78031b1
codex: address PR review feedback (#9513)
doudouOUC 97868f7
chore: merge origin/main into PR #9513
doudouOUC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Critical] A sole legacy uppercase UUID persisted in both active and archived storage is still unrestorable.
loadSession/resumeSessionnormalize the request to lowercase before this comparison, whilefindSessionIdIgnoringCase()returns the uppercase persisted spelling;candidateSessionId === sessionIdtherefore fails and returnssession_conflictalthough there is only one spelling. A focused probe reproduced both failures, and returning the sole persisted candidate made both pass. Please represent a sole spelling present in both states separately and restore that persisted spelling without requiring equality to the normalized request.中文
[严重] 仅以旧版大写 UUID 拼写同时存在于 active 和 archived 中的会话仍无法恢复。
loadSession/resumeSession会先把请求规范化为小写,而findSessionIdIgnoringCase()返回持久化的大写拼写,因此这里的candidateSessionId === sessionId会失败并返回session_conflict,即使实际上只有一种拼写。定向探针复现了 load 和 resume 的失败;返回唯一持久化候选后两者均通过。请把“同一唯一拼写同时存在于两个状态”建模为独立结果,并直接恢复该持久化拼写,不要要求它等于规范化后的请求。— gpt-5.6-sol@954e5164 via Qwen Code /review (v0.22.0)