-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(review): clear the deferred-suggestion backlog from #9175's review rounds #9342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f6e9869
fix(review): clear the deferred-suggestion backlog from #9175's revie…
wenshao f38007c
fix(review): stamp the phase that ran nothing — the budget-floor shap…
wenshao d138578
fix(review): take round 2's twelve — the union tells an empty own lis…
wenshao 92ccb88
fix(review): take round 3's six — a resume that ran suites drops the …
qwen-code-dev-bot 902db62
fix(review): take round 4's two — the CJK-tail parity split closes, t…
qwen-code-dev-bot 7738c47
Merge remote-tracking branch 'origin/main' into fix/review-deferred-b…
qwen-code-dev-bot 999f61d
fix(review): the merged persisted-anchor test takes the flags-object …
qwen-code-dev-bot 5a2c0e2
Merge branch 'main' into fix/review-deferred-backlog
qwen-code-dev-bot d597c63
Merge branch 'main' into fix/review-deferred-backlog
qwen-code-dev-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] The rewritten third-shape continuation sentence is pinned by no test at either prose site — this round's new pins (the adjacent
testScope.notRun/"clamped": truesentence) make the unpinned rewrite beside them stand out. No assertion in agent-prompt.test.ts matchesendedBeforeTests,UNFINISHED, orthird shape, neither in this resume paragraph nor in the role-7 base brief's matching sentence at lib/agent-briefs.ts:538. — Failure scenario: deleting the sentence ships green; Agent 7 then treats the endedBeforeTests shape as continuable and spends one of its MAX_RESUME_CALLS on a--resumethat can only answer "ended before its test phase" — the wasted-continuation loop the sentence exists to prevent.Witness (mutation probe this round): deleted the sentence at BOTH sites → full agent-prompt.test.ts suite
Tests 263 passed (263)— the deletion ships green.Suggested fix: pin a distinctive fragment per site, e.g.
expect(p).toContain('"endedBeforeTests": true')and the 'do not spend a continuation on it' clause, on both the buildRoleBrief resume paragraph and the BRIEFS role-7 brief.中文说明
重写后的「第三形态」续跑句子在两个文案位点都没有测试钉住——本轮新增的钉住(相邻的
testScope.notRun/"clamped": true句)反而让旁边这句未钉住的重写显得突出。agent-prompt.test.ts 中没有任何断言匹配endedBeforeTests、UNFINISHED或third shape,无论是这个续跑段落还是 lib/agent-briefs.ts:538 处 role-7 基础 brief 里的对应句子。失败场景:删除这句话后整个套件仍绿;Agent 7 随后会把 endedBeforeTests 形态当作可续跑,把一次 MAX_RESUME_CALLS 花在一个只能回答「ended before its test phase」的
--resume上——正是这句话要防止的浪费续跑循环。证据(本轮变异探针):在两个位点同时删除该句 → agent-prompt.test.ts 全套
Tests 263 passed (263)——删除后仍全绿。修复建议:在两个位点各钉一个可区分的片段,例如对 buildRoleBrief 续跑段落与 BRIEFS role-7 brief 同时断言
expect(p).toContain('"endedBeforeTests": true')与 'do not spend a continuation on it' 子句。— qwen3.8-max via Qwen Code /review (v0.21.13)