-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(web-shell): keep a manual session name across /clear (#8977) #9260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f8c9a3e
fix(web-shell): keep manual title across clear
yiliang114 729ec77
chore: merge latest main for CI
yiliang114 e7cfafc
fix(acp-bridge): reject an empty session displayName on metadata update
yiliang114 2648ce5
fix(web-shell): keep title provenance when metadata events echo the s…
yiliang114 e9f9f6b
fix(web-shell): discard an armed /clear carry when other paths bind a…
yiliang114 c914da5
Merge branch 'main' into fix/8977-clear-keeps-manual-session-name
yiliang114 4006098
Merge branch 'main' into fix/8977-clear-keeps-manual-session-name
yiliang114 4df3cae
Merge branch 'main' into fix/8977-clear-keeps-manual-session-name
yiliang114 e6bf281
Merge branch 'main' into fix/8977-clear-keeps-manual-session-name
yiliang114 7aefc9c
chore: merge latest main for CI
yiliang114 41d73cd
fix(serve): preserve automatic title provenance
yiliang114 1e3798b
Merge branch 'main' into fix/8977-clear-keeps-manual-session-name
yiliang114 d08ed52
test(serve): type automatic title metadata
yiliang114 7d449b5
fix(web-shell): keep clear recovery after rename failure
yiliang114 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Preserve manual titles across `/clear` | ||
|
|
||
| `/clear` creates a deferred successor session. Remember the current title only | ||
| when its persisted provenance is `manual`, then rename the successor before it | ||
| attaches and before its first prompt. | ||
|
|
||
| The existing session catalog is the durable source of title provenance after a | ||
| reload. Live rename events provide the same provenance without another read. | ||
| `/new`, `/reset`, session navigation, and workspace changes discard the carry. | ||
|
|
||
| Automatic and legacy titles with unknown provenance are never carried. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.