Repository navigation
fix(ci): narrow serve-ab's self-hosted wipe to the A/B checkout dirs #9228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e0e1d61
fix(ci): narrow serve-ab's self-hosted wipe to the A/B checkout dirs
qwen-code-dev-bot 2eeb0ce
test(ci): derive serve-ab wipe pin from the checkout paths (#9228)
qwen-code-dev-bot aa3ab19
test(ci): pin the serve-ab wipe's full executed script and step order…
qwen-code-dev-bot e765e1a
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot e7bb585
fix(ci): match serve-ab's wipe step name and pin to its narrowed scop…
qwen-code-dev-bot 900221e
fix(ci): exclude the shared root .git from serve-ab's self-hosted wip…
qwen-code-dev-bot 415d980
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot 8074297
fix(ci): keep only a real .git and scrub its exec state in serve-ab w…
qwen-code-dev-bot 664f791
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot 781a982
fix(ci): follow a symlinked workspace root in the serve-ab wipe (#9228)
qwen-code-dev-bot 50d038c
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot 2a2c6c4
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot a8a4ec6
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot d92db6d
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot a861aeb
Merge remote-tracking branch 'origin/main' into fix/serve-ab-narrow-s…
qwen-code-dev-bot 9658f76
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot 0323a69
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot c3357ee
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot 4fd6a7a
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot 51777f4
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot 9b5b134
fix(ci): defang the worktreeConfig bypass and anchor the serve-ab wip…
qwen-code-dev-bot 8306207
Merge branch 'main' into fix/serve-ab-narrow-self-hosted-wipe
qwen-code-dev-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declined — intentional strictness, not an oversight. This round's rework pins the wipe step's entire executed-line set (see the R2-1 thread), and that pin is deliberately exact: any change to the wipe script — a backslash continuation wrap or a trailing inline comment on the rm line included — must update the pin in the same diff. That friction is the point: an edit to this
rmgets a reviewer's eyes on the workflow change and the pin update together. The failure mode is safe: an innocent reformat produces red CI (fixed by re-pinning in the same PR), never a green CI hiding a widened wipe. Adding continuation-joining plus trailing-comment stripping to the guard is shell lexing inside a regression test — complexity for the very scenario the guard exists to catch. Note the strictness is pre-existing: the prior byte-exact pin also failed on a continuation wrap (your witness confirms), so the rework introduces no new friction here.中文说明
拒绝——这是有意的严格性,并非疏忽。本轮重构将 wipe 步骤的全部执行行集合作为固定对象(见 R2-1 线程),且该固定有意做到精确:wipe 脚本的任何改动——包括续行反斜杠换行或 rm 行尾的行内注释——都必须在同一 diff 中同步更新固定。这种摩擦正是目的所在:对该
rm的修改会让审阅者同时看到工作流改动与固定更新。失败模式也是安全的:无辜的重排只会导致红色 CI(在同一 PR 中重新固定即可修复),绝不会出现放宽 wipe 却绿灯通过。在守卫中加入续行合并与行尾注释剥离,等于在回归测试里做 shell 词法解析——是为守卫本就要拦截的场景增加复杂度。另外,此严格性并非新增:此前的逐字节固定同样会在续行换行时失败(你的见证也证实了这一点),因此本轮重构没有引入新的摩擦。