Repository navigation
fix(review): lock the PR review worktree lease against concurrent sessions #9211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
baa828e
fix(review): lock the PR review worktree lease against concurrent ses…
wenshao 95db313
fix(review): roll back the lease on fetch-pr failures and scope the m…
qwen-code-dev-bot 6f3a68e
fix(review): shield live leases from the cleanup sweep and roll back …
qwen-code-dev-bot 2a7d9a5
Merge remote-tracking branch 'origin/main' into fix/review-worktree-l…
qwen-code-dev-bot 80e69da
fix(review): re-check the lease after cleanup's audit to close a TOCT…
qwen-code-dev-bot e865fbc
fix(review): validate fetch-pr's number and release leases off side-f…
0da76ba
Merge remote-tracking branch 'origin/main' into fix/review-worktree-l…
2473f80
Merge branch 'main' into fix/review-worktree-lease-lock
qwen-code-dev-bot 5c852cd
fix(review): acquire review leases atomically and fail closed on iden…
01f6755
Merge remote-tracking branch 'origin/main' into fix/review-worktree-l…
b4d4f1d
Merge remote-tracking branch 'origin/main' into fix/review-worktree-l…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferred to the next round, not dropped. This round ran in critical-only mode with the ~8-finding cap, and the batch went to the five Criticals (atomic lease acquire, guarded rollback, fail-closed identity, platform-safe assertion, win32-gated ENOTDIR test) plus the three cheapest coherent Suggestions. R5-3 is pure test-order hygiene, and the finding's own probe confirms no current test is affected (34/34 green across four shuffled-seed orders), so it deferred safely. The
beforeEachincleanup.test.tsalready resetsrmSyncfor exactly this hazard class; extending it toreaddirSync/execFileSyncremains a small, agreed change for the follow-up round this thread stays open for.中文说明
延后到下一轮,不会丢弃。本轮处于仅处理 Critical 的模式并受约 8 个发现的上限约束,批次给了五个 Critical(原子租约获取、有守卫的回滚、fail-closed 身份校验、平台安全断言、win32 门控的 ENOTDIR 测试)以及三个最廉价且与主线一致的 Suggestion。R5-3 是纯测试顺序卫生,且该发现自己的探针确认当前无测试受影响(四次乱序种子下均 34/34 全绿),因此可以安全延后。
cleanup.test.ts的beforeEach已为同一隐患类别重置了rmSync;把它扩展到readdirSync/execFileSync仍是本线程保持开放所对应的小幅后续改动。