-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(web-shell): improve sidebar session management #9122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
7c2585d
feat(web-shell): improve sidebar session management
a9e32d5
Merge branch 'main' into codex/web-shell-sidebar-session-details
wenshao e06097a
Merge branch 'main' into codex/web-shell-sidebar-session-details
qwen-code-dev-bot 764c076
feat(web-shell): keep sessions accessible when sidebar is collapsed
2093af6
Merge remote-tracking branch 'origin/codex/web-shell-sidebar-session-…
5816dd6
test(web-shell): cover hover session details
0357d6b
test(web-shell): align workspace sidebar coverage
4127cf0
fix(web-shell): keep collapsed session actions open
1af1690
fix(web-shell): layer collapsed session menus
4b02211
Merge branch 'main' into codex/web-shell-sidebar-session-details
qwen-code-dev-bot 80b97ad
Merge branch 'main' into codex/web-shell-sidebar-session-details
qwen-code-dev-bot 71b6dc4
Merge branch 'main' into codex/web-shell-sidebar-session-details
qwen-code-dev-bot b3497b1
fix(web-shell): address sidebar session details review findings (#9122)
qwen-code-dev-bot 9d6f0eb
fix(web-shell): resolve standing sidebar session details blockers (#9…
qwen-code-dev-bot 9cfd169
fix: address round-6 review findings in serve metadata and sidebar (#…
qwen-code-dev-bot 52fca13
fix: address round-7 review findings in serve metadata and sidebar (#…
qwen-code-dev-bot 9a8e8a6
fix: address round-8 review findings in sidebar rename and switcher (…
qwen-code-dev-bot 84e5b76
fix: address round-9 review findings in sidebar rename and menus (#9122)
qwen-code-dev-bot cab964f
fix: address round-10 review findings in sidebar actions and rename (…
qwen-code-dev-bot 2fee896
Merge branch 'main' into codex/web-shell-sidebar-session-details
qwen-code-dev-bot ebed5d9
Merge branch 'main' into codex/web-shell-sidebar-session-details
qwen-code-dev-bot ccf1f68
Merge branch 'main' into codex/web-shell-sidebar-session-details
qwen-code-dev-bot 5d6bc65
Merge branch 'main' into codex/web-shell-sidebar-session-details
qwen-code-dev-bot b8825e7
Merge remote-tracking branch 'origin/main' into codex/web-shell-sideb…
qwen-code-dev-bot 6eff160
Merge branch 'main' into codex/web-shell-sidebar-session-details
qwen-code-dev-bot 97f3fca
fix(web-shell): remove unsafe rename unmount cleanup
e854130
fix(web-shell): stabilize sidebar session mutations
30b74a4
fix(web-shell): polish sidebar session interactions
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
41 changes: 41 additions & 0 deletions
41
docs/design/2026-08-13-web-shell-sidebar-session-details.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Web Shell sidebar session details | ||
|
|
||
| ## Goal | ||
|
|
||
| Make session rows easier to scan without adding another navigation surface: | ||
|
|
||
| - show the existing details panel from row hover and remove the Details action | ||
| from the overflow menu; | ||
| - preview five sessions per expanded folder or session group, with an explicit | ||
| control to reveal the remainder until that section is collapsed; | ||
| - move timestamps into the details panel and reserve the row's trailing slot | ||
| for branch or worktree state; | ||
| - fade overflowing titles at the right edge and scroll them slowly on hover; | ||
| - use a neutral spinner for running sessions; | ||
| - keep the brand, New task action, and footer fixed while the remaining | ||
| navigation and session content share one scroll area. | ||
|
|
||
| ## Design | ||
|
|
||
| The row remains the only session-selection and keyboard target. A controlled | ||
| Radix popover is anchored to it and opens only from pointer hover. The panel | ||
| does not participate in keyboard navigation; its session ID copy action is a | ||
| pointer-only affordance. The panel contains the title and relative time, final | ||
| workspace path segment, optional git branch or worktree, session status, and a | ||
| copyable session ID. Existing action menus keep all mutation actions but no | ||
| longer include Details. Rename targets the selected session through its owning | ||
| workspace, so current, background, secondary-workspace, and archived sessions | ||
| share the same action. | ||
|
|
||
| Session limits are local UI state. Direct workspace lists and grouped lists | ||
| show the first five items; revealing the remainder is not persisted, so | ||
| collapsing and reopening the owning section restores the five-item preview. | ||
|
|
||
| Title overflow uses a CSS mask for the trailing fade. On hover, one DOM width | ||
| measurement supplies the exact scroll distance to a CSS animation, avoiding a | ||
| timer or dependency. | ||
|
|
||
| The workspace-qualified metadata route keeps background-session renames inside | ||
| the resolved workspace runtime. Its dedicated `workspace_session_metadata` | ||
| capability prevents clients from exposing the action against older daemons | ||
| that do not mount the route. No session schema changes are required. |
15 changes: 15 additions & 0 deletions
15
docs/design/2026-08-14-web-shell-collapsed-session-switcher.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Web Shell collapsed session switcher | ||
|
|
||
| ## Goal | ||
|
|
||
| Keep session switching available while the sidebar is collapsed without adding | ||
| another navigation model. | ||
|
|
||
| ## Design | ||
|
|
||
| The collapsed sidebar shows one Project icon in the scrolling navigation area. | ||
| Pointer hover or click opens a Popover containing the same complete session | ||
| browser used by the expanded sidebar. Source tabs, pinned and live sessions, | ||
| project search, workspace actions, grouping, preview limits, archived sessions, | ||
| and expansion preferences therefore follow one implementation in both states. | ||
| Selecting a session closes the Popover. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.