Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d24b9e6
refactor(review): extract the toolchain adapter boundary
wenshao Aug 9, 2026
374105b
docs(review): record the toolchain adapter boundary design
wenshao Aug 9, 2026
95e5ba6
feat(review): add Maven multi-module verification
wenshao Aug 9, 2026
ece4bb6
Merge branch 'main' into review-toolchain-adapter-p0
wenshao Aug 9, 2026
83f298a
Merge branch 'review-toolchain-adapter-p0' into review-maven-toolchain
wenshao Aug 9, 2026
5969deb
Merge remote-tracking branch 'origin/main' into review-maven-toolchain
wenshao Aug 11, 2026
f508461
fix(review): close the Maven adapter's fail-open gaps from review
wenshao Aug 11, 2026
07530d9
fix(review): close the Maven toolchain's second-round fail-open gaps
qwen-code-ci-bot Aug 11, 2026
a8ad503
fix(review): close the Maven toolchain's third-round fail-open gaps
qwen-code-ci-bot Aug 11, 2026
67dfe9c
fix(review): close the Maven toolchain's fourth-round review gaps
qwen-code-ci-bot Aug 12, 2026
7ea10c4
fix(review): close the Maven toolchain's fifth-round review gaps
qwen-code-ci-bot Aug 12, 2026
f82cbb8
fix(review): close the Maven toolchain's sixth-round review gaps
qwen-code-ci-bot Aug 12, 2026
eb2263c
fix(review): close the Maven toolchain's seventh-round review gaps
qwen-code-ci-bot Aug 12, 2026
f70f82c
Merge branch 'main' into review-maven-toolchain
qwen-code-dev-bot Aug 12, 2026
cae4a9d
Merge branch 'main' into review-maven-toolchain
wenshao Aug 13, 2026
231e32a
Merge branch 'main' into review-maven-toolchain
qwen-code-dev-bot Aug 13, 2026
ca33cae
fix(review): close the Maven toolchain's eighth-round review gaps
qwen-code-dev-bot Aug 13, 2026
47a085c
refactor(review): close the Maven XML-corner class with a strict parser
wenshao Aug 13, 2026
58fda41
test(review): decouple Maven verdict-note assertions from exact prose
wenshao Aug 13, 2026
9c77660
fix(review): close round-1 findings on the Maven toolchain
wenshao Aug 14, 2026
25f4e3f
fix(review): keep a capped never-ran run out of the definitive ruling
wenshao Aug 14, 2026
5ee1d07
fix(review): close round-2 findings on the Maven toolchain
wenshao Aug 14, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
450 changes: 428 additions & 22 deletions docs/design/review-toolchain-adapters.md

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
"qrcode-terminal": "^0.12.0",
"react": "^19.2.4",
"read-package-up": "^11.0.0",
"saxes": "^6.0.0",
"shell-quote": "^1.9.0",
"simple-git": "^3.36.0",
"string-width": "^7.1.0",
Expand All @@ -107,14 +108,14 @@
"@types/node": "^22.0.0",
"@types/prompts": "^2.4.9",
"@types/qrcode-terminal": "^0.12.2",
"@types/ws": "^8.5.0",
"@types/react": "^19.1.8",
"@types/react-dom": "^19.1.6",
"@types/semver": "^7.7.0",
"@types/shell-quote": "^1.7.5",
"@types/supertest": "^6.0.3",
"@types/yauzl": "^2.9.1",
"@types/ws": "^8.5.0",
"@types/yargs": "^17.0.32",
"@types/yauzl": "^2.9.1",
"archiver": "^7.0.1",
"ink-testing-library": "^4.0.0",
"jsdom": "^26.1.0",
Expand Down
24 changes: 23 additions & 1 deletion packages/cli/src/commands/review/agent-prompt.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2166,8 +2166,30 @@ describe('buildRoleBrief — every agent, not just the territory ones', () => {
// send the reader to fix a prompt that is correct.
const p = buildRoleBrief(PR_PLAN, '7');
expect(p).not.toContain(PLAN.diffPathAbsolute);
expect(p).toContain('npm run build');
expect(p).toContain('`toolchain: "maven"`');
expect(p).toContain('Do not run `test-delta` for Maven in this release');
expect(p).toContain('Source: [build]');
// The only steering against hand-run full builds — the pattern the same
// paragraph records as timing out 71 times and verifying nothing. The
// prohibition is scoped to what build-test runs: the unsupported
// fallback below it is the sanctioned hand-run path, and the wording
// must not forbid it.
expect(p).toContain(
'Do **not** substitute hand-written npm or Maven commands ' +
'for what `build-test` runs — the `toolchain: "unsupported"` fallback ' +
'below is the only sanctioned hand-run path',
);
// The unsupported bullet's steering rules: a fail-closed adapter
// result must not be replaced by an ad hoc command, the mixed-root
// note names the Maven half the npm run did not verify (and forbids
// filling it ad hoc), and a CI-named command lifts neither rule.
// Reverting the bullet to the old precedence list left all tests green
// before these pins.
expect(p).toContain(
'do not replace that fail-closed result with an ad hoc Maven command',
);
expect(p).toContain('do not run Maven ad hoc to fill the gap');
expect(p).toContain('does **not** lift the two rules above');
});

it('pins Agent 7 to the PR worktree and hands it the test-efficacy probe', () => {
Expand Down
Loading
Loading