Skip to content
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2837be6
fix(cli): prevent dialog clipping in short terminals
shenyankm Aug 13, 2026
1ba8a96
fix(cli): address dialog height review feedback
shenyankm Aug 13, 2026
ae05ca6
test(cli): pin dialog height budget branches and document locked-skil…
shenyankm Aug 13, 2026
477fab8
fix(cli): make dialog height budgets width-aware
shenyankm Aug 13, 2026
46c9d09
fix(cli): harden dialog height budgets
shenyankm Aug 14, 2026
ba35a4c
fix(cli): shed dialog chrome below the height-budget floor
shenyankm Aug 14, 2026
42303a5
test(cli): pin round-5 budget fixes
shenyankm Aug 14, 2026
07b371d
fix(cli): translate the locked-skills subtitle badge
shenyankm Aug 14, 2026
2cf2dd5
fix(cli): shed skills dialog chrome to the bare list at tiny budgets
shenyankm Aug 14, 2026
4d98703
fix(cli): simplify short skills dialog handling
shenyankm Aug 14, 2026
44f20a4
test(cli): pin review round-9 suggestions for dialog height fix
shenyankm Aug 14, 2026
a77698e
fix(cli): address dialog height review feedback
shenyankm Aug 15, 2026
d1590f1
fix(cli): preserve dialog search and label behavior
shenyankm Aug 15, 2026
7e2ce19
chore(cli): merge main into dialog-height fix, reconciling skills dialog
qwen-code-dev-bot Sep 1, 2026
3ca6695
test(cli): restore skills dialog config mock
shenyankm Sep 2, 2026
30908bb
Merge branch 'main' into fix/dialog-height-overflow
wenshao Sep 4, 2026
68ea6ff
Merge branch 'main' into fix/dialog-height-overflow
wenshao Sep 6, 2026
e4cbcad
chore: merge upstream main into dialog height fix
shenyankm Sep 12, 2026
1643d93
fix(cli): preserve locked skill search within height budgets
shenyankm Sep 12, 2026
0cd5121
docs: record PR 9040 review and verification follow-ups
shenyankm Sep 12, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions docs/design/short-skills-dialog.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Short Skills Dialog

## Decision

When `/skills` receives a terminal-height constraint, its rows are reserved for
the dialog chrome and workspace-toggleable skills. Higher-scope-locked skills
are represented by a count and are not included in constrained search results.

Without a height constraint, the dialog keeps the complete read-only locked
section and filters it with the search query.

## Invariants

- A constrained dialog never renders more rows than its supplied budget.
- At least one matching actionable row remains visible when one exists.
- Bare mode ignores a retained hidden query for filtering, Vim navigation, and
Escape handling.
2 changes: 2 additions & 0 deletions docs/users/features/status-line.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ The easiest way to configure a status line is the `/statusline` command. It open

This opens the preset mode configurator. Use arrow keys to navigate, space to toggle items, and enter to confirm. Your selection is saved to settings automatically.

When fewer than 16 rows are available, the dialog switches to a compact list-only layout without search or preview.

You can also give `/statusline` specific instructions to have it generate a command-mode configuration:

```
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/i18n/locales/ca.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,10 @@ export default {
'type to filter…': 'escriviu per filtrar…',
'No skills are currently available.':
'No hi ha habilitats disponibles actualment.',
'All available skills are locked at a higher scope (see below).':
'Totes les habilitats disponibles estan bloquejades en un àmbit superior (veure a sota).',
'No skills match the search.': 'Cap habilitat coincideix amb la cerca.',
'Locked by higher-scope settings (cannot toggle here):':
"Bloquejades per paràmetres d'àmbit superior (aquí no es poden commutar):",
'(+{{count}} locked)': '(+{{count}} bloquejada(s))',
'higher scope': 'àmbit superior',
' {{name}} {{description}} [locked: {{scope}}]':
' {{name}} {{description}} [bloquejada: {{scope}}]',
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/i18n/locales/de.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,10 @@ export default {
'Search:': 'Suche:',
'type to filter…': 'Tippen zum Filtern…',
'No skills are currently available.': 'Derzeit sind keine Skills verfügbar.',
'All available skills are locked at a higher scope (see below).':
'Alle verfügbaren Skills sind in einer höheren Ebene gesperrt (siehe unten).',
'No skills match the search.': 'Keine Skills passen zur Suche.',
'Locked by higher-scope settings (cannot toggle here):':
'Gesperrt durch Einstellungen einer höheren Ebene (kann hier nicht umgeschaltet werden):',
'(+{{count}} locked)': '(+{{count}} gesperrt)',
'higher scope': 'höhere Ebene',
' {{name}} {{description}} [locked: {{scope}}]':
' {{name}} {{description}} [gesperrt: {{scope}}]',
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/i18n/locales/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -361,11 +361,10 @@ export default {
'Search:': 'Search:',
'type to filter…': 'type to filter…',
'No skills are currently available.': 'No skills are currently available.',
'All available skills are locked at a higher scope (see below).':
'All available skills are locked at a higher scope (see below).',
'No skills match the search.': 'No skills match the search.',
'Locked by higher-scope settings (cannot toggle here):':
'Locked by higher-scope settings (cannot toggle here):',
'(+{{count}} locked)': '(+{{count}} locked)',
'higher scope': 'higher scope',
' {{name}} {{description}} [locked: {{scope}}]':
' {{name}} {{description}} [locked: {{scope}}]',
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/i18n/locales/fr.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,11 @@ export default {
'type to filter…': 'tapez pour filtrer…',
'No skills are currently available.':
'Aucune compétence n’est actuellement disponible.',
'All available skills are locked at a higher scope (see below).':
'Toutes les compétences disponibles sont verrouillées à une portée supérieure (voir ci-dessous).',
'No skills match the search.':
'Aucune compétence ne correspond à la recherche.',
'Locked by higher-scope settings (cannot toggle here):':
'Verrouillées par des paramètres de portée supérieure (impossible de basculer ici) :',
'(+{{count}} locked)': '(+{{count}} verrouillée(s))',
'higher scope': 'portée supérieure',
' {{name}} {{description}} [locked: {{scope}}]':
' {{name}} {{description}} [verrouillée : {{scope}}]',
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/i18n/locales/ja.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,10 @@ export default {
'Search:': '検索:',
'type to filter…': 'フィルタを入力…',
'No skills are currently available.': '利用可能なスキルはありません。',
'All available skills are locked at a higher scope (see below).':
'すべての利用可能なスキルは上位スコープでロックされています(下記参照)。',
'No skills match the search.': '検索に一致するスキルはありません。',
'Locked by higher-scope settings (cannot toggle here):':
'上位スコープ設定によってロックされています(ここでは切替不可):',
'(+{{count}} locked)': '(+{{count}} 件ロック中)',
'higher scope': '上位スコープ',
' {{name}} {{description}} [locked: {{scope}}]':
' {{name}} {{description}} [ロック中:{{scope}}]',
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/i18n/locales/pt.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,10 @@ export default {
'type to filter…': 'digite para filtrar…',
'No skills are currently available.':
'Nenhuma habilidade está disponível no momento.',
'All available skills are locked at a higher scope (see below).':
'Todas as habilidades disponíveis estão bloqueadas em um escopo superior (veja abaixo).',
'No skills match the search.': 'Nenhuma habilidade corresponde à pesquisa.',
'Locked by higher-scope settings (cannot toggle here):':
'Bloqueado por configurações de escopo superior (não é possível alternar aqui):',
'(+{{count}} locked)': '(+{{count}} bloqueado(s))',
'higher scope': 'escopo superior',
' {{name}} {{description}} [locked: {{scope}}]':
' {{name}} {{description}} [bloqueado: {{scope}}]',
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/i18n/locales/ru.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,10 @@ export default {
'Search:': 'Поиск:',
'type to filter…': 'введите для фильтрации…',
'No skills are currently available.': 'Сейчас навыков нет.',
'All available skills are locked at a higher scope (see below).':
'Все доступные навыки заблокированы на более высоком уровне (см. ниже).',
'No skills match the search.': 'Нет навыков, соответствующих поиску.',
'Locked by higher-scope settings (cannot toggle here):':
'Заблокированы настройками более высокого уровня (здесь переключить нельзя):',
'(+{{count}} locked)': '(+{{count}} заблокировано)',
'higher scope': 'более высокий уровень',
' {{name}} {{description}} [locked: {{scope}}]':
' {{name}} {{description}} [заблокировано: {{scope}}]',
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/i18n/locales/zh-TW.js
Original file line number Diff line number Diff line change
Expand Up @@ -335,11 +335,10 @@ export default {
'Search:': '搜尋:',
'type to filter…': '輸入以篩選…',
'No skills are currently available.': '目前沒有可用的技能。',
'All available skills are locked at a higher scope (see below).':
'所有可用技能都被更高範圍鎖定(詳見下方)。',
'No skills match the search.': '沒有符合搜尋條件的技能。',
'Locked by higher-scope settings (cannot toggle here):':
'被更高範圍設定鎖定(此處無法切換):',
'(+{{count}} locked)': '(+{{count}} 個已鎖定)',
'higher scope': '更高範圍',
' {{name}} {{description}} [locked: {{scope}}]':
' {{name}} {{description}} [已鎖定:{{scope}}]',
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/i18n/locales/zh.js
Original file line number Diff line number Diff line change
Expand Up @@ -349,11 +349,10 @@ export default {
'Search:': '搜索:',
'type to filter…': '输入以过滤…',
'No skills are currently available.': '当前没有可用的技能。',
'All available skills are locked at a higher scope (see below).':
'所有可用技能都被更高范围锁定(详见下方)。',
'No skills match the search.': '没有匹配搜索的技能。',
'Locked by higher-scope settings (cannot toggle here):':
'被更高范围设置锁定(此处无法切换):',
'(+{{count}} locked)': '(+{{count}} 个已锁定)',
'higher scope': '更高范围',
' {{name}} {{description}} [locked: {{scope}}]':
' {{name}} {{description}} [已锁定:{{scope}}]',
Expand Down
Loading
Loading