feat(review): dispatch Step 3A's fan-out from a generated workflow script, and route to it

packages/cli/src/commands/review.test.ts

@@ -54,6 +54,7 @@ describe('reviewCommand', () => {
       'comment-status',
       'load-rules',
       'agent-prompt',
+      'emit-workflow',
       'build-test',
       'base-tree',
       'test-delta',

packages/cli/src/commands/review.ts

@@ -25,6 +25,7 @@ import { publishAssetsCommand } from './review/publish-assets.js';
 import { resolveAnchorsCommand } from './review/resolve-anchors.js';
 import { checkCoverageCommand } from './review/check-coverage.js';
 import { agentPromptCommand } from './review/agent-prompt.js';
+import { emitWorkflowCommand } from './review/emit-workflow.js';
 import { buildTestCommand } from './review/build-test.js';
 import { baseTreeCommand } from './review/base-tree.js';
 import { testDeltaCommand } from './review/test-delta.js';
@@ -65,6 +66,7 @@ export const reviewCommand: CommandModule = {
       .command(commentStatusCommand)
       .command(loadRulesCommand)
       .command(agentPromptCommand)
+      .command(emitWorkflowCommand)
       .command(buildTestCommand)
       .command(baseTreeCommand)
       .command(testDeltaCommand)
@@ -86,7 +88,7 @@ export const reviewCommand: CommandModule = {
       .command(cleanupCommand)
       .demandCommand(
         1,
-        'Specify a subcommand: run, parse-args, match-remote, meta, issue-context, fetch-diff, comment-body, fetch-pr, capture-local, plan-diff, repo-context, pr-context, comment-status, load-rules, agent-prompt, build-test, base-tree, test-delta, drive, mock-provider, extract-step, script-lint, resolve-anchors, check-coverage, cost-ledger, presubmit, test-efficacy, test-plan, findings, publish-assets, compose-review, save-artifact, submit, or cleanup.',
+        'Specify a subcommand: run, parse-args, match-remote, meta, issue-context, fetch-diff, comment-body, fetch-pr, capture-local, plan-diff, repo-context, pr-context, comment-status, load-rules, agent-prompt, emit-workflow, build-test, base-tree, test-delta, drive, mock-provider, extract-step, script-lint, resolve-anchors, check-coverage, cost-ledger, presubmit, test-efficacy, test-plan, findings, publish-assets, compose-review, save-artifact, submit, or cleanup.',
       )
       .version(false),
   handler: () => {

packages/cli/src/commands/review/agent-prompt.ts

@@ -1767,12 +1767,15 @@ export function findingsSection(
  * Build one agent's brief and launch prompt, write the brief beside the plan, and
  * return the key and the prompt for the caller to record and print.
  *
- * One body for both callers on purpose: the single-agent path and `--roster` must
- * emit byte-identical prompts for the same agent, because the delivery check
- * compares agents against records — a drift between the two paths would read as a
- * rewritten launch on a run that did everything right.
+ * One body for every caller on purpose: the single-agent path, `--roster` and
+ * `emit-workflow` must emit byte-identical prompts for the same agent, because
+ * the delivery check compares agents against records — a drift between the
+ * paths would read as a rewritten launch on a run that did everything right.
+ * Exported for that reason: a caller that rebuilt this would be a second
+ * implementation of the invariant, and byte-parity would become something a
+ * test asserts rather than something the code cannot break.
  */
-function buildLaunch(
+export function buildLaunch(
   report: PlanReport,
   planPath: string,
   spec: {

packages/cli/src/commands/review/cleanup.test.ts

@@ -97,6 +97,8 @@ vi.mock('./lib/paths.js', () => ({
   tmpFile: (target: string, suffix: string) =>
     `/repo/.qwen/tmp/qwen-review-${target}-${suffix}`,
   tmpPrefix: (target: string) => `qwen-review-${target}-`,
+  REVIEW_WORKFLOWS_DIR: '/repo/.qwen/workflows',
+  REVIEW_WORKFLOW_PREFIX: 'qwen-review-',
 }));
 
 import {
@@ -140,6 +142,38 @@ describe('runCleanup', () => {
     expect(mocks.clearReviewWorktreeLease).not.toHaveBeenCalled();
   });
 
+  // `emit-workflow` has to write its generated fan-out script into the
+  // saved-workflow dir — the Workflow loader refuses anything outside it — and
+  // that dir is also the user's own saved workflows, where each file is a
+  // `/<name>` slash command. A review that left one behind would hand the user
+  // a permanent command for a diff that no longer exists.
+  it('sweeps generated fan-out scripts out of the saved-workflow dir', () => {
+    mocks.execFileSync.mockReturnValue(Buffer.from(''));
+    mocks.existsSync.mockImplementation(
+      ((p: string) => p === '/repo/.qwen/workflows') as never,
+    );
+    mocks.readdirSync.mockImplementation(((dir: string) =>
+      dir === '/repo/.qwen/workflows'
+        ? ['qwen-review-9ea13ef11a.js', 'my-own-workflow.js', 'notes.md']
+        : []) as never);
+
+    runCleanup('pr-123');
+
+    expect(mocks.rmSync).toHaveBeenCalledWith(
+      '/repo/.qwen/workflows/qwen-review-9ea13ef11a.js',
+      { force: true },
+    );
+    // A user's own saved workflow shares the directory and must survive.
+    expect(mocks.rmSync).not.toHaveBeenCalledWith(
+      '/repo/.qwen/workflows/my-own-workflow.js',
+      expect.anything(),
+    );
+    expect(mocks.rmSync).not.toHaveBeenCalledWith(
+      '/repo/.qwen/workflows/notes.md',
+      expect.anything(),
+    );
+  });
+
   it('clears the lease when cleanup succeeds', () => {
     mocks.execFileSync.mockReturnValue(Buffer.from(''));
 

packages/cli/src/commands/review/cleanup.ts

@@ -41,6 +41,8 @@ import {
   baseWorktreePath,
   reviewBranch,
   REVIEW_TMP_DIR,
+  REVIEW_WORKFLOWS_DIR,
+  REVIEW_WORKFLOW_PREFIX,
   tmpFile,
   tmpPrefix,
 } from './lib/paths.js';
@@ -595,6 +597,44 @@ export function runCleanup(target: string): void {
     }
   }
 
+  // --- Generated fan-out scripts (under .qwen/workflows/) ---------------
+  // `emit-workflow` has to write its script into the saved-workflow dir —
+  // `Workflow({scriptPath})` refuses to load anything outside it. That dir is
+  // also the user's own saved workflows, and each generated script is a
+  // `/<name>` slash command in their session, so a review that leaves one
+  // behind hands the user a permanent command for a diff that no longer
+  // exists. Swept by prefix, not by name: a run killed before it could report
+  // its path still leaves a file, and the target it belonged to is not
+  // recoverable from the name (which is a plan-path digest).
+  let workflowEntries: string[] = [];
+  try {
+    workflowEntries = existsSync(REVIEW_WORKFLOWS_DIR)
+      ? readdirSync(REVIEW_WORKFLOWS_DIR)
+      : [];
+  } catch (err) {
+    writeStderrLine(
+      `Failed to read ${REVIEW_WORKFLOWS_DIR}: ${(err as Error).message}`,
+    );
+  }
+
+  for (const file of workflowEntries) {
+    if (!file.startsWith(REVIEW_WORKFLOW_PREFIX) || !file.endsWith('.js')) {
+      continue;
+    }
+    const full = join(REVIEW_WORKFLOWS_DIR, file);
+    try {
+      rmSync(full, { force: true });
+      writeStdoutLine(`Removed generated workflow: ${full}`);
+      removedAny = true;
+    } catch (err) {
+      writeStderrLine(`Failed to remove ${full}: ${(err as Error).message}`);
+      failedAny = true;
+    }
+  }
+
+  // A generated script that will not delete is a side file, like the record
+  // directories above: it sets `failedAny` for the summary line but must NOT
+  // hold the lease, which guards only the worktree and branch.
   if (!failedDestruction) {
     clearReviewWorktreeLease(process.cwd(), target);
   }