Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
13b181b
fix(webui): retry session load while closing
yiliang114 Aug 10, 2026
6ac08da
fix(desktop): support enterprise LAN addresses
yiliang114 Aug 10, 2026
a8b0b1f
fix(desktop): reject unbounded LAN masks
yiliang114 Aug 10, 2026
0d8791f
chore(desktop): sync 0.1.1 candidate with main
yiliang114 Aug 10, 2026
aebd9f7
Merge remote-tracking branch 'origin/main' into codex/desktop-011-rel…
yiliang114 Aug 10, 2026
04267c5
fix(webui): close desktop session and voice regressions
yiliang114 Aug 10, 2026
2039865
Merge remote-tracking branch 'origin/main' into codex/desktop-011-rel…
yiliang114 Aug 10, 2026
5b64ce9
fix(desktop): refresh signed runtime checksums
yiliang114 Aug 10, 2026
2d64eae
fix(desktop): close 0.1.1 regression gaps
yiliang114 Aug 10, 2026
da2477b
fix(webui): make quick voice presses start recording
yiliang114 Aug 10, 2026
97c5103
fix(webui): make quick voice presses start recording
yiliang114 Aug 10, 2026
a929e88
fix(web-shell): keep voice clicks responsive
yiliang114 Aug 10, 2026
f57a9bd
fix(webui): settle timed-out session loads cleanly
yiliang114 Aug 10, 2026
81e5eb7
fix(web-shell): keep voice clicks responsive
yiliang114 Aug 10, 2026
51c9d48
fix(desktop): finalize interaction regressions
yiliang114 Aug 10, 2026
11b2a30
fix(web-shell): preserve hold click semantics
yiliang114 Aug 10, 2026
59ab9be
fix(desktop): reject stale packaged runtimes
yiliang114 Aug 10, 2026
400fe53
fix(serve): avoid cancelling closed sessions
yiliang114 Aug 10, 2026
4baaa3c
fix(web-shell): preserve hold click suppression
yiliang114 Aug 11, 2026
d011c0e
fix(desktop): consolidate 0.1.1 regressions
yiliang114 Aug 11, 2026
e727b57
fix(web-shell): preserve hold click suppression
yiliang114 Aug 11, 2026
b30e12a
fix(desktop): center and localize local control
yiliang114 Aug 11, 2026
904bc23
Merge remote-tracking branch 'origin/main' into cx/resolve-8896
yiliang114 Aug 11, 2026
6f7be7f
test(desktop): pin interaction regressions
yiliang114 Aug 11, 2026
68f3934
Merge remote-tracking branch 'origin/main' into cx/resolve-8896
yiliang114 Aug 11, 2026
76e1c39
fix: close network and session race gaps
yiliang114 Aug 11, 2026
b99649e
Merge branch 'main' into codex/desktop-011-followups
yiliang114 Aug 11, 2026
6965a6e
Merge branch 'main' into codex/desktop-011-followups
yiliang114 Aug 11, 2026
f3dd3ab
fix(desktop): remove duplicate network.contains check in spawn_proxy
yiliang114 Aug 11, 2026
a62448d
Merge commit 'refs/codex/pr-8884-base' into pr-8896
yiliang114 Aug 11, 2026
ef1f96b
fix(desktop): clear stale click suppression and exclude virtual inter…
yiliang114 Aug 11, 2026
01c4ff2
test(desktop): cover cross-platform close fallbacks
yiliang114 Aug 11, 2026
87d09b1
Merge remote-tracking branch 'origin/main' into codex/desktop-011-fol…
yiliang114 Aug 11, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/desktop-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -316,10 +316,6 @@ jobs:
working-directory: 'packages/desktop-shell'
run: 'npm run build:runtime'

- name: 'Verify bundled runtime'
working-directory: 'packages/desktop-shell'
run: 'npm run smoke:runtime'

- name: 'Run desktop tests'
working-directory: 'packages/desktop-shell'
run: 'npm test'
Expand Down Expand Up @@ -361,6 +357,15 @@ jobs:
echo "::warning::Node.js runtime binary not found at $node_bin; no Node.js binary signed."
fi

- name: 'Refresh bundled runtime checksums after signing (macOS)'
Comment thread
yiliang114 marked this conversation as resolved.
Resolved
if: "runner.os == 'macOS' && inputs.dry_run == false"
Comment thread
yiliang114 marked this conversation as resolved.
Resolved
working-directory: 'packages/desktop-shell'
run: 'node scripts/prepare-runtime.js --refresh-checksums'

- name: 'Verify bundled runtime'
working-directory: 'packages/desktop-shell'
run: 'npm run smoke:runtime'

- name: 'Build desktop installers'
working-directory: 'packages/desktop-shell'
shell: 'bash'
Expand Down
17 changes: 13 additions & 4 deletions packages/desktop-shell/scripts/prepare-runtime.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@ const sourceRoot = process.env.QWEN_CODE_ROOT
: repoRoot;
const runtimeDir = path.join(packageDir, 'runtime');
const packageRoot = path.join(runtimeDir, 'qwen-code');
const refreshChecksums = process.argv.indexOf('--refresh-checksums');
Comment thread
yiliang114 marked this conversation as resolved.
Resolved
if (refreshChecksums !== -1) {
const root = process.argv[refreshChecksums + 1]
? path.resolve(process.argv[refreshChecksums + 1])
: packageRoot;
writeChecksums(root);
console.log(`Refreshed desktop runtime checksums at ${root}`);
process.exit(0);
}
const libDir = path.join(packageRoot, 'lib');
const nodeDir = path.join(packageRoot, 'node');
const qwenCodeVersion = JSON.parse(
Expand Down Expand Up @@ -249,18 +258,18 @@ function gitCommit(directory) {
}).trim();
}

function writeChecksums() {
function writeChecksums(root = packageRoot) {
const checksums = {};
for (const file of runtimeFiles(packageRoot)) {
const relative = path.relative(packageRoot, file).split(path.sep).join('/');
for (const file of runtimeFiles(root)) {
const relative = path.relative(root, file).split(path.sep).join('/');
if (relative === 'checksums.json') continue;
checksums[relative] = crypto
.createHash('sha256')
.update(fs.readFileSync(file))
.digest('hex');
}
fs.writeFileSync(
path.join(packageRoot, 'checksums.json'),
path.join(root, 'checksums.json'),
`${JSON.stringify(checksums, null, 2)}\n`,
);
}
Expand Down
23 changes: 14 additions & 9 deletions packages/web-shell/client/voice/VoiceButton.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,16 @@ const pointer = (
type: 'pointerdown' | 'pointerup' | 'pointercancel',
pointerId = 1,
mouseButton = 0,
timeStamp?: number,
) => {
const event = new MouseEvent(type, {
bubbles: true,
button: mouseButton,
});
Object.defineProperty(event, 'pointerId', { value: pointerId });
if (timeStamp !== undefined) {
Object.defineProperty(event, 'timeStamp', { value: timeStamp });
}
act(() => {
button.dispatchEvent(event);
});
Expand Down Expand Up @@ -637,7 +641,7 @@ describe('VoiceButton', () => {
if (!button) throw new Error('VoiceButton did not render');
const heldButton = button;

pointer(button, 'pointerdown');
pointer(button, 'pointerdown', 1, 0, 1_000);
expect(mocks.capture.start).toHaveBeenCalledOnce();

mocks.capture.status = 'recording';
Expand All @@ -656,20 +660,24 @@ describe('VoiceButton', () => {
// capture set on pointerdown survives the status change and the release
// still lands on this element.
expect(button).toBe(heldButton);
pointer(button, 'pointerup');
pointer(button, 'pointerup', 1, 0, 1_500);
click(button);

expect(mocks.capture.stop).toHaveBeenCalledOnce();
});

it('stops a hold that is released while connecting', async () => {
it('keeps a quick hold active as a tap', async () => {
Comment thread
yiliang114 marked this conversation as resolved.
Resolved
const { root, container } = mount(false);
await flush();
let button = container.querySelector('button');
const button = container.querySelector('button');
if (!button) throw new Error('VoiceButton did not render');
pointer(button, 'pointerdown');
pointer(button, 'pointerup');
click(button);

mocks.capture.status = 'connecting';
expect(mocks.capture.stop).not.toHaveBeenCalled();
Comment thread
yiliang114 marked this conversation as resolved.
Resolved

mocks.capture.status = 'recording';
act(() => {
root.render(
<VoiceButton
Expand All @@ -679,10 +687,7 @@ describe('VoiceButton', () => {
/>,
);
});
button = container.querySelector('button');
if (!button) throw new Error('VoiceButton did not render');
pointer(button, 'pointerup');

click(container.querySelector('button')!);
expect(mocks.capture.stop).toHaveBeenCalledOnce();
});

Expand Down
24 changes: 21 additions & 3 deletions packages/web-shell/client/voice/VoiceButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import styles from './VoiceButton.module.css';
/** Live waveform bar count in the recording pill. */
const BAR_COUNT = 16;
const NOTICE_TIMEOUT_MS = 2_000;
const HOLD_THRESHOLD_MS = 250;

export interface VoiceButtonProps {
/** Insert the final transcript into the composer (user reviews, then sends). */
Expand Down Expand Up @@ -118,6 +119,8 @@ export function VoiceButton({
mode: 'hold',
}));
const holdPointerIdRef = useRef<number | null>(null);
const holdStartedAtRef = useRef(0);
const ignoreNextClickRef = useRef(false);
const targetRef = useRef(target);
targetRef.current = target;
const requestGenerationRef = useRef(0);
Expand Down Expand Up @@ -310,7 +313,13 @@ export function VoiceButton({
const canCancel = isRecording || isConnecting;

const handleClick = (event: React.MouseEvent<HTMLButtonElement>) => {
if (voiceGate.mode === 'hold' && event.detail !== 0) return;
if (voiceGate.mode === 'hold') {
const ignore = event.detail !== 0 && ignoreNextClickRef.current;
ignoreNextClickRef.current = false;
if (ignore || (event.detail !== 0 && !isRecording && !isConnecting)) {
return;
}
}
if (isRecording) {
stop();
} else if (isConnecting) {
Expand All @@ -322,6 +331,7 @@ export function VoiceButton({
};

const handlePointerDown = (event: React.PointerEvent<HTMLButtonElement>) => {
if (voiceGate.mode === 'hold') ignoreNextClickRef.current = false;
if (
voiceGate.mode !== 'hold' ||
event.button !== 0 ||
Expand All @@ -333,6 +343,8 @@ export function VoiceButton({
}
event.preventDefault();
holdPointerIdRef.current = event.pointerId;
holdStartedAtRef.current = event.timeStamp;
ignoreNextClickRef.current = true;
try {
event.currentTarget.setPointerCapture(event.pointerId);
} catch {
Expand All @@ -350,7 +362,12 @@ export function VoiceButton({
return;
}
holdPointerIdRef.current = null;
if (isConnecting || isRecording) stop();
if (
event.timeStamp - holdStartedAtRef.current >= HOLD_THRESHOLD_MS &&
(isConnecting || isRecording)
) {
stop();
}
};

const handlePointerCancel = (
Expand All @@ -363,7 +380,8 @@ export function VoiceButton({
return;
}
holdPointerIdRef.current = null;
if (isConnecting || isRecording) abort();
ignoreNextClickRef.current = false;
abort();
Comment thread
yiliang114 marked this conversation as resolved.
Resolved
};

const label = isRecording
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2551,7 +2551,6 @@ export function DaemonSessionProvider(props: DaemonSessionProviderProps) {
setConnection((current) => ({
...current,
status: 'disconnected',
Comment thread
yiliang114 marked this conversation as resolved.
Resolved
error: `Reconnecting in ${delayMs}ms`,
}));
Comment thread
yiliang114 marked this conversation as resolved.
Resolved
await delay(delayMs, abort.signal);
}
Expand Down
Loading