Repository navigation
fix(web-shell): keep workspace picker suggestions closed #8844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b3d4802
fix(web-shell): close workspace suggestions on blur
67c0e3d
fix(web-shell): read suggestion focus gate from the input root (#8844)
qwen-code-dev-bot 220b3c3
fix(web-shell): reset suggestion suppress flag after a Browse pick (#…
qwen-code-dev-bot ee45d9b
Merge branch 'main' into codex/fix-web-shell-workspace-registration
qwen-code-dev-bot 4f251d1
Merge branch 'main' into codex/fix-web-shell-workspace-registration
qwen-code-dev-bot c78557b
Merge branch 'main' into codex/fix-web-shell-workspace-registration
qwen-code-dev-bot 0e80df0
fix(web-shell): resolve picker blur-timer races in suggestion gating …
qwen-code-dev-bot 2ff92ea
test(web-shell): cover re-blur timer cancellation in AddWorkspaceDial…
qwen-code-dev-bot b503758
fix(web-shell): clear blur timer on focus and unmount in AddWorkspace…
qwen-code-dev-bot 797a75f
fix(web-shell): invalidate blurred lookups via sequence counter in Ad…
qwen-code-dev-bot ff555e0
fix(web-shell): clear stale suggestions on blur dismiss in AddWorkspa…
qwen-code-dev-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] Error path for
pickDirectorynot tested forsuppressNextFetchOpenRefclearing — Thefinallyblock inpickDirectoryrunssuppressNextFetchOpenRef.current = falsefor all three outcomes (success, cancelled, error). The cancelled and success paths are tested by the new tests; the error path is not. If a future refactor moves the flag-clearing out of thefinallyblock and into the success-only path, the error test would pass while the error path would silently suppress the next suggestion fetch.中文说明
pickDirectory的finally块在所有三种结果(成功、取消、错误)下都会执行suppressNextFetchOpenRef.current = false。取消和成功路径已由新测试覆盖;错误路径尚未覆盖。如果未来重构将标志清除移出finally块并仅放入成功路径,该错误测试仍会通过,但错误路径将静默抑制下一次建议查询。建议在错误测试中添加onSuggest并在错误解决后输入路径断言建议列表打开。— deepseek-v4-flash via Qwen Code /review (v0.21.8)