-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(review): add Maven multi-module verification #8777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d24b9e6
refactor(review): extract the toolchain adapter boundary
wenshao 374105b
docs(review): record the toolchain adapter boundary design
wenshao 95e5ba6
feat(review): add Maven multi-module verification
wenshao ece4bb6
Merge branch 'main' into review-toolchain-adapter-p0
wenshao 83f298a
Merge branch 'review-toolchain-adapter-p0' into review-maven-toolchain
wenshao 5969deb
Merge remote-tracking branch 'origin/main' into review-maven-toolchain
wenshao f508461
fix(review): close the Maven adapter's fail-open gaps from review
wenshao 07530d9
fix(review): close the Maven toolchain's second-round fail-open gaps
qwen-code-ci-bot a8ad503
fix(review): close the Maven toolchain's third-round fail-open gaps
qwen-code-ci-bot 67dfe9c
fix(review): close the Maven toolchain's fourth-round review gaps
qwen-code-ci-bot 7ea10c4
fix(review): close the Maven toolchain's fifth-round review gaps
qwen-code-ci-bot f82cbb8
fix(review): close the Maven toolchain's sixth-round review gaps
qwen-code-ci-bot eb2263c
fix(review): close the Maven toolchain's seventh-round review gaps
qwen-code-ci-bot f70f82c
Merge branch 'main' into review-maven-toolchain
qwen-code-dev-bot cae4a9d
Merge branch 'main' into review-maven-toolchain
wenshao 231e32a
Merge branch 'main' into review-maven-toolchain
qwen-code-dev-bot ca33cae
fix(review): close the Maven toolchain's eighth-round review gaps
qwen-code-dev-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] The pin stops right before the carve-out clause (— the toolchain:"unsupported" fallback below is the only sanctioned hand-run path) that is the only thing reconciling the prohibition with the sanctioned fallback, even though the test's own comment declares the carve-out load-bearing. — Failure scenario: Deleting or inverting the em-dash clause leaves the pinned substring intact and the test green, while Agent 7's brief flatly forbids hand-run commands at the same time as its unsupported bullet instructs one build + one test command — on any toolchain:"unsupported" report the agent is wedged between running nothing and violating the prohibition.
Suggested fix: Extend the pin across the clause: expect(p).toContain('for what
build-testruns — thetoolchain: "unsupported"fallback below is the only sanctioned hand-run path').中文说明
钉住断言恰好停在 carve-out 子句之前(—— 下方 toolchain:"unsupported" 回退是唯一获准的手动运行路径),而该子句是调和解禁与获准回退的唯一内容,测试自己的注释还声明该 carve-out 是关键。 —— 失败场景:删除或反转这个破折号子句后,被钉住的子串原封不动、测试仍绿,而 Agent 7 的 brief 一边绝对禁止手写命令、一边其 unsupported bullet 又指示执行一次构建 + 一次测试 —— 任何 toolchain:"unsupported" 报告都会让 agent 在'什么都不跑'与'违反禁令'之间被夹住。
建议修复:把钉住扩展到子句:expect(p).toContain('for what
build-testruns — thetoolchain: "unsupported"fallback below is the only sanctioned hand-run path')。— qwen3.8-max via Qwen Code /review (v0.21.9)